Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update stripe API version to 2020-03-02 #206

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Update stripe API version to 2020-03-02 #206

wants to merge 1 commit into from

Conversation

dav1do
Copy link

@dav1do dav1do commented Dec 7, 2021

  • Add 2020-03-02 and 2020-08-27 API versions to the enum
  • Set API header 2020-03-02 on the client. This is a breaking change but 0.13 is supposed to target 2020-03-02 according to the readme.

Questions:

  • Does openAPI spec regen need to happen?
  • Since Stripe uses the version of your account if you don't pass the header, it seems nice to leave off/add a new_with_version constructor, however there are probably compatibility issues with the generated types in that case, so maybe the library can only support one version at a time.

@dav1do dav1do force-pushed the fix/update-api-version branch from ca0a4a5 to 23b8222 Compare December 7, 2021 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav1do @fisherdarling