Skip to content

Commit

Permalink
firmware: rockchip: use sp_el1 from bl31 delivers
Browse files Browse the repository at this point in the history
we think 'if (fiq_pt_regs.pstate & 0x10)' doesn't make any
sense, use sp_el1 from bl31 delivers is ok.

Change-Id: I0792d76e39912b4ca5484b029761daac05cd719b
Signed-off-by: chenjh <chenjh@rock-chips.com>
  • Loading branch information
JosephChen2017 authored and rkhuangtao committed Jun 5, 2017
1 parent 8aaa053 commit 8616b35
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions drivers/firmware/rockchip_sip.c
Original file line number Diff line number Diff line change
Expand Up @@ -144,13 +144,7 @@ static struct pt_regs sip_fiq_debugger_get_pt_regs(void *reg_base,

/* copy pstate */
memcpy(&fiq_pt_regs.pstate, reg_base + 0x110, 8);

/* EL1 mode */
if (fiq_pt_regs.pstate & 0x10)
memcpy(&fiq_pt_regs.sp, reg_base + 0xf8, 8);
/* EL0 mode */
else
fiq_pt_regs.sp = sp_el1;
fiq_pt_regs.sp = sp_el1;

/* copy pc */
memcpy(&fiq_pt_regs.pc, reg_base + 0x118, 8);
Expand Down

0 comments on commit 8616b35

Please sign in to comment.