-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add titleSuffix
as future replacement for header.organisationName
option
#298
Conversation
As well as moving this option, it could be renamed to something like |
I think Do we need to keep |
If we remove it and anyone has set a custom suffix, then it’ll revert back to |
I've renamed to titleSuffix but kept the backwards-compatibility for now. But feel free to remove that if you don’t think it’ll affect anyone significantly. |
Maybe we keep the backwards compatibility for now, and remove in v7. We can add an issue and assign it to the v7.0 milestone. I’m expecting that to have a number of breaking changes, given it will change how layouts are loaded from the plugin (and likely see a move to ES module syntax, too). |
Moves the organisationName config option out from the `header` config option to be a top-level config option. This is now only used in the title tag.
7fe2c40
to
5f783c0
Compare
titleSuffix
as future replacement for header.organisationName
option
… option (#298) Adds `titleSuffix` option to replace the undocumented `header.organisationName` option as this value is now only used in the document title. --------- Co-authored-by: Paul Robert Lloyd <me+git@paulrobertlloyd.com>
This moves the organisationName config option out from the
header
config option to be a top-level config option namedtitleSuffi
, as it is now only used in the title tag.To avoid a breaking change,
header.organisationName
is still supported a fallback. This could be removed in a future breaking change release.Additionally, if both
titleSuffix
andheader.organisationName
are set tofalse
, then the-
will not be added to the title tag (for scenarios where an title suffix might not be needed).