Allow missing breadcrumb navigation items #352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
eleventyExcludeFromCollections
option is enabled, thecollections.all
array will not contain all pages, resulting ineleventyNavigationBreadcrumb()
throwing a "Node does not exist" exception, which manifests as an opaque nunjucks error that is difficult for the reader to trace.This change uses the
allowMissing
option ofeleventyNavigationBreadcrumb()
to effectively allow this scenario to fail silently (no breadcrumb will appear at all rather than failing to compile).In our case, we use
eleventyExcludeFromCollections
to exclude some dynamically generated pages fromcollections.all
for performance reasons.We're using 11ty v3.0.0, but
allowMissing
is a valid option foreleventyNavigation@0.3.5
.@paulrobertlloyd I figured this would be a relatively safe option to hardcode into the base template, but do you think it warrants exposing as an option to consumers of this plugin?