Simplify the choice of text for legends and labels #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding by presence is a more-descriptive approach that compacting and selecting the first remaining item. This refactoring also gives us the opportunity to improve the test cases around whether or not captions are rendered when the legend or label: * is nil * has nil text * text is an empty string
peteryates
force-pushed
the
refactor-some-compact-first-chains
branch
from
0f063f7
to
1c27692
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finding by presence is a more-descriptive approach than compacting the array and selecting the first remaining item.
It also gives us the opportunity to make the behaviour around label/legend rendering more intuitive when the key:
nilniltext"")Now, empty strings will fail Rails'
#presencecheck and be treated likenil. This means that if you pass#govuk_text_field(label: { text: "" })the label will fall back to the localised or default value instead of rendering an empty<label>element.