Allow legend size to be nil #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for govuk-form-builder pending review.Visit the deploys page to approve it
|
This updates the legend element to allow the size attribute to be `nil`, and when `nil` a size class won't be specified for the element. This is required to support the case where a field has a legend element but shouldn't have a size class. There's an example of this kind of component in the GOV.UK Design System: https://design-system.service.gov.uk/components/date-input/#if-youre-asking-more-than-one-question-on-the-page It's currently not possible to re-create this example using purely the form builder classes as the size is enforced as one of `s`, `m`, `l` or `xl`.
thomasleese
force-pushed
the
legend-size-nil
branch
from
8ca528a
to
6d4f042
Compare
peteryates
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the legend element to allow the size attribute to be
nil, and whennila size class won't be specified for the element. This is required to support the case where a field has a legend element but shouldn't have a size class.There's an example of this kind of component in the GOV.UK Design System:
https://design-system.service.gov.uk/components/date-input/#if-youre-asking-more-than-one-question-on-the-page
It's currently not possible to re-create this example using purely the form builder classes as the size is enforced as one of
s,m,lorxl.