Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #89, I said (emphasis added):
Turns out, that’s not quite true. Because we are providing a renderer, this is incompatible with the
marked-gfm-heading-id
extension.Enable
marked-gfm-heading-id
before this extension, and itsid
s will be removed.Enable
marked-gfm-heading-id
after this extension, and our heading classes will be removed.So let’s provide heading ids in our extension, which we can create using our own slugger. This may not be as robust as the one
marked
previously included (which usedgithub-slugger
under the hood), but should cater to 99.9% of use cases.(We might have been able to use
github-slugger
, were it not for the fact that this package exports a Common JS module for compatibility with the GOV.UK Prototype Kit.)