Throwing a warning in the admin when Show Avatars is disabled.

[Japh]

Just updated my sites to Stream 1.4.4 and noticed that when Show Avatars is disabled (not selected) in Settings > Discussion, the following warning is displayed, twice for each "author", at the top of the Stream admin page:

Warning: assert(): Assertion failed in /home/[...]/public_html/wp-content/plugins/stream/includes/class-wp-stream-author.php on line 119

Doesn't break the site, but it definitely doesn't look good. Thought you'd want to know...

Originally reported on the WordPress.org forums

[shadyvb]

I'm on it.

[Japh]

No, I am :)

[shadyvb]

@Japh wp-cli avatar still shows while the 'show_avatars' setting is disabled, we might need to address this here as well.

[westonruter]

Oh yeah. The WP_Stream_Author class manually supplies an image for the
system user.

[Japh]

Thanks for the heads up, @shadyvb. Fixed that now.

[shadyvb]

Cool, @fjarrett This needs to be issued as a hotfix to prevent notices on installations with show_avatars=false, probably lots of them are there.