Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Show Avatars disabled, issue #518 #519

Merged
merged 6 commits into from
May 11, 2014
Merged

Fix for Show Avatars disabled, issue #518 #519

merged 6 commits into from
May 11, 2014

Conversation

Japh
Copy link

@Japh Japh commented May 10, 2014

This fixes #518 and is ready for review and merge, @fjarrett / @lukecarbis.

@Japh
Copy link
Author

Japh commented May 10, 2014

Perhaps? Thoughts, @westonruter?

@westonruter
Copy link
Contributor

My perspective is that assert shouldn't be relied on for anything functional. But I like throwing it in to just quickly check for assumptions. But I don't feel strongly about it.

@shadyvb
Copy link
Contributor

shadyvb commented May 10, 2014

Yea, it is intended for debugging/testing only, should not be used in production.

frankiejarrett added a commit that referenced this pull request May 11, 2014
@frankiejarrett
Merge pull request #519 from x-team/issue-518
b10e5ca 
Fix for Show Avatars disabled, issue #518
@frankiejarrett frankiejarrett merged commit b10e5ca into develop May 11, 2014
@frankiejarrett frankiejarrett deleted the issue-518 branch May 11, 2014 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throwing a warning in the admin when Show Avatars is disabled.
4 participants
@Japh @westonruter @shadyvb @frankiejarrett