Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream runs install routine twice #528

Closed
shadyvb opened this issue May 14, 2014 · 1 comment · Fixed by #533
Closed

Stream runs install routine twice #528

shadyvb opened this issue May 14, 2014 · 1 comment · Fixed by #533
Labels
bug

Comments

@shadyvb
Copy link
Contributor

shadyvb commented May 14, 2014

Once included in verify_database_present:
https://github.com/x-team/wp-stream/blob/1.4.4/stream.php#L216

which is attached to init in:
https://github.com/x-team/wp-stream/blob/1.4.4/stream.php#L75

And the second attached directly to init in:
https://github.com/x-team/wp-stream/blob/1.4.4/stream.php#L116

Not sure if it was justified, so asking for clarification here.
/cc @fjarrett @c3mdigital
@shadyvb shadyvb added the bug label May 14, 2014
@frankiejarrett
Copy link
Contributor

@shadyvb Nice observation! It looks like this one can be removed. I'll test thoroughly.

@frankiejarrett frankiejarrett mentioned this issue May 15, 2014
Merged
@frankiejarrett frankiejarrett self-assigned this May 15, 2014
@frankiejarrett frankiejarrett mentioned this issue May 21, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove duplicate call to install() method xwp/stream
2 participants
@shadyvb @frankiejarrett