Remove duplicate call to install() method

[frankiejarrett]

Resolves #528

This removes a second call of install() that is already handled earlier by the verify_database_present() method.

Also removes duplicate use of the wp_stream_no_tables filter in install() that is also handled beforehand by verify_database_present().

I've tested in single site and multisite. Fresh installs and DB upgrade routines are working in both.

@shadyvb @lukecarbis Please review

[lukecarbis]

I don't like that verify_database_present() does more than you would expect it to by reading it's name. It should be verify_database_present_and_install() (which is a bit ugly).

But then, I prefer the idea that functions do one thing only.

Would this approach work instead?

1. Add install() to the init hook during __construct
2. Add verify_database_present() to the wp_stream_no_tables hook during __construct
3. Remove the apply_filters( 'wp_stream_no_tables' ) conditional from the verify_database_present() function
4. Add the apply_filters( 'wp_stream_no_tables' ) conditional to the install function (before installing)
5. Remove the self::install() call made by verify_database_present()

This approach says "install, but do a check to see if the database exists before you get too far". Rather than, "check to see if the database exists, and if it does, install". The focus of our logic should be on installing, not verifying, IMO.

Or have I missed something?

[frankiejarrett]

@lukecarbis Nice idea.

[frankiejarrett]

@lukecarbis Actually I don't see how we can use wp_stream_no_tables inside the __construct because it's just a filter used to pass a boolean value. But I'll try a different approach based on this concept.

[lukecarbis]

👍 Much better.