Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Navigation] Gutenberg 18.1 reduced specificity breaks link text-decoration #11

Open
justintadlock opened this issue May 12, 2024 · 0 comments
Open

[Navigation] Gutenberg 18.1 reduced specificity breaks link text-decoration #11

justintadlock opened this issue May 12, 2024 · 0 comments
Assignees
@justintadlock
Labels
🐛 Bug I installed this, and now my website is broken. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?

Comments

@justintadlock
Copy link
Contributor

Nested link styles in theme.json, specifically for text-decoration, is broken when using Gutenberg 18.1. This PR reduces the specificity of the global styles selector, wrapping everything in :where():

With that change in place, the Core CSS wins the specificity battle, overruling theme.json: https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/navigation/style.scss#L79-L88

Block library style updates were in included in this PR, but the Navigation block was not included:
@justintadlock justintadlock added 🐛 Bug I installed this, and now my website is broken. WordPress Issue Whatcha doin' to me WordPress/Gutenberg? labels May 12, 2024
@justintadlock justintadlock self-assigned this May 12, 2024
justintadlock added a commit that referenced this issue May 12, 2024
@justintadlock
Overwrite Gutenberg's hardcoded nav link text-decoration.
5bffecb 
This is a partial, hardcoded solution for: #11

Ideally, we can remove this at some point in favor of styling via `theme.json`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justintadlock justintadlock

Labels
🐛 Bug I installed this, and now my website is broken. WordPress Issue Whatcha doin' to me WordPress/Gutenberg?
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@justintadlock