-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for menu icons #47
Conversation
While technically I'm in favor to have this but I'm not a huge fan about the black background, is there a way to add transparency support for pngs/icos? |
Yes, it's possible. Accessing the DI bitmap bits from a handle returned by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without the black background thats way better, I left some comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like it. Regarding the icons, did you create them? I would like to avoid any copyright claims regarding legal concerns, also I'm asking if you are the author of the logo would you like to sponsor it to be generally used for this project?
Well, I created the logo based on the x64Dbg logo, but the other icons are slightly modified versions from the visual studio image library, and as far I know, it's free to use then. If this is not a problem, I don't mind letting them for this project |
Well I guess this will be the official logo from now on then, thanks! |
I added a simple binding for setting icons in the menus.
The resources added to the project are only suggestions/placeholders.
Preview: