Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for menu icons #47

Merged
merged 5 commits into from
Nov 22, 2021
Merged

Added support for menu icons #47

merged 5 commits into from
Nov 22, 2021

Conversation

Guila767
Copy link
Contributor

I added a simple binding for setting icons in the menus.
The resources added to the project are only suggestions/placeholders.

Preview:

image

@ZehMatt
Copy link
Collaborator

ZehMatt commented Nov 20, 2021

While technically I'm in favor to have this but I'm not a huge fan about the black background, is there a way to add transparency support for pngs/icos?

@Guila767
Copy link
Contributor Author

Yes, it's possible. Accessing the DI bitmap bits from a handle returned by Bitmap::GetHbitmap() makes the alpha channel data get lost. The alpha channel and a miss configuration on the BITMAPV5HEADER make the transparency of the icons not work. I'm already working on the solution.

@Guila767
Copy link
Contributor Author

Menu icons with transparency

Preview

Copy link
Collaborator

@ZehMatt ZehMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the black background thats way better, I left some comments.

src/Bindings/UI.cpp Outdated Show resolved Hide resolved
src/Bindings/UI.cpp Outdated Show resolved Hide resolved
Copy link
Collaborator

@ZehMatt ZehMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it. Regarding the icons, did you create them? I would like to avoid any copyright claims regarding legal concerns, also I'm asking if you are the author of the logo would you like to sponsor it to be generally used for this project?

@Guila767
Copy link
Contributor Author

Well, I created the logo based on the x64Dbg logo, but the other icons are slightly modified versions from the visual studio image library, and as far I know, it's free to use then. If this is not a problem, I don't mind letting them for this project

@ZehMatt
Copy link
Collaborator

ZehMatt commented Nov 22, 2021

Well I guess this will be the official logo from now on then, thanks!

@ZehMatt ZehMatt merged commit 3ad45bc into x64dbg:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants