Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update PluginCommon to rebuild with acf #10

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Conversation

xCykrix
Copy link
Owner

@xCykrix xCykrix commented Nov 15, 2023

Pull Request

Summary and Information

Update PluginCommon upstream shared library to build with new acf version.

Referencing Issue(s): #9

Fixing Issue(s): #

Summary of Testing

To what extent did you test this pull request? Did any tests require
modification to result in a passing state (breaking changes)?

I tested this PR by ... (description of testing methods)

  • Tests passed with no modification.
  • Tests passed with modification.
  • Tests are not currently passing.
  • Tests need to be added to exist for the case covered in this issue.

Checklist for Integrity

  • The changes follow the style guidelines defined in the project.
  • I have performed a self-review of my code, including testing intentionally
    incorrect information.
  • I have commented my code, particularly in hard to understand or complex
    areas.
  • The changes have not generated any new errors or warning by
    static-analysis tooling.
  • All dependant changes have been merged and published in downstream
    modules.
  • To the best of my knowledge, all information in this pull request is
    vulnerability free and well researched.
    • This pull request may require more research or analysis of complex logic
      or technology.
    • This pull request contains regular expression addition or modifications
      which may need verification.
    • This pull request contains database logic which may need verification of
      proper user-input sterilization.

@xCykrix xCykrix self-assigned this Nov 15, 2023
@xCykrix xCykrix linked an issue Nov 15, 2023 that may be closed by this pull request
@xCykrix xCykrix merged commit d21ca07 into main Nov 15, 2023
1 check passed
@xCykrix xCykrix deleted the 9-acf-stacktrace-1202 branch November 15, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACF Stacktrace 1.20.2
1 participant