CI Check #1
Closed
CI Check #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
force-pushed
the
00000-lintcheck-crates
branch
4 times, most recently
from
ddfea5f to
a0fd315
Compare
…r=y21 Lint `zero_repeat_side_effects` only if array length is a literal zero changelog: [`zero_repeat_side_effects` ] Lint only if array length is a literal zero Fixes rust-lang#13110 . r? y21
…p-suggestion, r=Alexendoo Fix wrong suggestion for `single_element_loop` where parens were missing Fixes rust-lang#12782. changelog: Fix missing parens in `single_element_loop` suggestion
…nks, r=Alexendoo Lintcheck: Add URL to lint emission place in diff This PR adds links to the emission code in our lintcheck CI. When reviewing changes, I would like to be able to see the bigger context, which isn't always included in the lint message. This PR adds a nice link to the lintcheck diff that allows for simple investigation of the code in question. At first, I wanted to simply use the doc.rs links and call it a day, but then I figured out that some crates might have their source files remapped. Cargo was the crate that made me notice this. As a response, I made the link configurable. (See rust-lang/docs.rs#2551 for a detailed explanation and possible solution to remove this workaround in the future.) It's probably easiest to review the individual commits. The last one is just a dummy to showcase the change. [:framed_picture: rendered :framed_picture:](https://github.com/rust-lang/rust-clippy/actions/runs/9960834924?pr=13104) --- r? `@Alexendoo` changelog: none --- That's it, I hope that everyone who's reading this has a beautiful day :D
xFrednet
force-pushed
the
00000-lintcheck-crates
branch
2 times, most recently
from
45badc3 to
5a51bf0
Compare
xFrednet
force-pushed
the
00000-lintcheck-crates
branch
from
5a51bf0 to
796ade6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.