Replace PAC dependency w/ new internal VI module #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new internal definition of VI registers, related types, and documenting comments replaces the dependency on n64-pac. This also removes a duplicate transitive dependency (proc-bitfield). Primary motivations for this change: - Documenting comments and links to reference material on each register, bitfield, and enum - Enable additional types and macros to improve ergonomics - Fewer external dependencies Most of the time spent has been learning about each VI field and analog television in general; much less time has been spent on the ergonomics of the interface, which have gotten slightly worse. Future types, macros, and defaults (e.g. for NTSC constants) are part of the growing todo list.
xSetech
commented
Oct 24, 2023
| /// | ||
| #[derive(Clone, Copy, PartialEq, Eq)] | ||
| pub struct VI_V_CURRENT(pub u32): IntoRaw, FromRaw { | ||
| pub half_line: u16 @ 0..=9, |
There was a problem hiding this comment.
Self-note to consider typing the last bit as a bool enum (even/odd field)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new internal definition of VI registers, related types, and documenting comments replaces the dependency on n64-pac. This also removes a duplicate transitive dependency (proc-bitfield).
Primary motivations for this change:
Most of the time spent has been learning about each VI field and analog television in general; much less time has been spent on the ergonomics of the interface, which have gotten slightly worse. Future types, macros, and defaults (e.g. for NTSC constants) are part of the growing todo list.