lint

Signed-off-by: Xavier Dupre <xadupre@microsoft.com>
xadupre · Jul 28, 2023 · aab9a65 · aab9a65
1 parent a859095
commit aab9a65
Show file tree

Hide file tree

Showing 27 changed files with 339 additions and 173 deletions.
diff --git a/docs/examples/plot_convert_lightgbm.py b/docs/examples/plot_convert_lightgbm.py
@@ -18,7 +18,9 @@
 +++++++++++++
 
 """
-
+import os
+import matplotlib.pyplot as plt
+from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 import numpy
 import onnx
 import sklearn
@@ -83,9 +85,6 @@
 # ++++++++++++++++++++++
 #
 # Finally, let's see the graph converted with *onnxmltools*.
-import os
-import matplotlib.pyplot as plt
-from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 
 pydot_graph = GetPydotGraph(
     onx.graph,

diff --git a/docs/examples/plot_convert_sklearn.py b/docs/examples/plot_convert_sklearn.py
@@ -30,7 +30,9 @@
 A very basic example using random forest and
 the iris dataset.
 """
-
+import os
+import matplotlib.pyplot as plt
+from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 import numpy
 import onnx
 import sklearn
@@ -93,9 +95,6 @@
 # ++++++++++++++++++++++
 #
 # Finally, let's see the graph converted with *onnxmltools*.
-import os
-import matplotlib.pyplot as plt
-from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 
 pydot_graph = GetPydotGraph(
     onx.graph,

diff --git a/docs/examples/plot_convert_sparkml.py b/docs/examples/plot_convert_sparkml.py
@@ -18,8 +18,11 @@
 +++++++++++++
 
 """
+
 import os
 import numpy
+import matplotlib.pyplot as plt
+from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 from pandas import DataFrame
 import onnx
 import sklearn
@@ -29,8 +32,6 @@
 import onnxruntime as rt
 import pyspark
 from pyspark.sql import SparkSession
-from pyspark.ml.classification import LogisticRegression
-from pyspark.ml.classification import LogisticRegression
 from pyspark.ml.feature import VectorAssembler, StringIndexer
 import onnxmltools
 from onnxconverter_common.data_types import FloatTensorType
@@ -114,9 +115,6 @@ def stop_spark(spark):
 # ++++++++++++++++++++++
 #
 # Finally, let's see the graph converted with *onnxmltools*.
-import os
-import matplotlib.pyplot as plt
-from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 
 pydot_graph = GetPydotGraph(
     onx.graph,

diff --git a/docs/examples/plot_convert_xgboost.py b/docs/examples/plot_convert_xgboost.py
@@ -18,8 +18,10 @@
 +++++++++++++
 
 """
-
+import os
 import numpy
+import matplotlib.pyplot as plt
+from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 import onnx
 import sklearn
 from sklearn.datasets import load_iris
@@ -84,9 +86,6 @@
 # ++++++++++++++++++++++
 #
 # Finally, let's see the graph converted with *onnxmltools*.
-import os
-import matplotlib.pyplot as plt
-from onnx.tools.net_drawer import GetPydotGraph, GetOpNodeProducer
 
 pydot_graph = GetPydotGraph(
     onx.graph,

diff --git a/onnxmltools/convert/common/_container.py b/onnxmltools/convert/common/_container.py
@@ -21,7 +21,8 @@ class H2OModelContainer(CommonSklearnModelContainer):
 class SparkmlModelContainer(RawModelContainer):
     def __init__(self, sparkml_model):
         super(SparkmlModelContainer, self).__init__(sparkml_model)
-        # Sparkml models have no input and output specified, so we create them and store them in this container.
+        # Sparkml models have no input and output specified,
+        # so we create them and store them in this container.
         self._inputs = []
         self._outputs = []
 
@@ -34,12 +35,14 @@ def output_names(self):
         return [variable.raw_name for variable in self._outputs]
 
     def add_input(self, variable):
-        # The order of adding variables matters. The final model's input names are sequentially added as this list
+        # The order of adding variables matters. The final model's
+        # input names are sequentially added as this list
         if variable not in self._inputs:
             self._inputs.append(variable)
 
     def add_output(self, variable):
-        # The order of adding variables matters. The final model's output names are sequentially added as this list
+        # The order of adding variables matters.
+        # The final model's output names are sequentially added as this list
         if variable not in self._outputs:
             self._outputs.append(variable)
 

diff --git a/onnxmltools/convert/common/interface.py b/onnxmltools/convert/common/interface.py
@@ -1,6 +1,7 @@
 # SPDX-License-Identifier: Apache-2.0
 
 # This file defines the interface of the converter internal object for callback,
-# So the usage of the methods and properties list here will not be affected among the different versions.
+# So the usage of the methods and properties list here
+# will not be affected among the different versions.
 
 from onnxconverter_common.interface import *  # noqa