Skip to content

Commit

Permalink
Allow 'xbd' package types to use <AndroidNamespaceReplacement>. (#1020
Browse files Browse the repository at this point in the history
)

I don't remember why I thought these needed to be disabled.  Allow 'xbd' package types to use `<AndroidNamespaceReplacement>`.

Note that `metadata` specified package names take precedence over `<AndroidNamespaceReplacement>` names, so GPS packages still work unchanged.

Additionally, by coexisting, this would allow us to slowly migrate GPS to `<AndroidNamespaceReplacement>` in the future if desired instead of needing to migrate all 1000+ `metadata` names in one big PR.
  • Loading branch information
jpobst authored Oct 21, 2024
1 parent 2bb9e9d commit 3bf781a
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions source/_PackageLevelCustomizations.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -55,14 +55,3 @@
<EmbeddedJar Include="..\..\externals\com.xamarin.google.android.play.feature.delivery.extensions\extensions.jar" />
</ItemGroup>
}

@if (Model.Type == AndroidBinderator.BindingType.XamarinBuildDownload
&& Model.NuGetPackageId != "Xamarin.Google.Android.InstallReferrer"
&& Model.NuGetPackageId != "Xamarin.Google.UserMessagingPlatform"
&& Model.NuGetPackageId != "Xamarin.Google.Assistant.AppActions.Widgets"
) {
<ItemGroup>
<!-- GPS doesn't currently use <AndroidNamespaceReplacement> -->
<AndroidNamespaceReplacement Remove="@@(AndroidNamespaceReplacement)" />
</ItemGroup>
}

0 comments on commit 3bf781a

Please sign in to comment.