Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress binding warnings. #1025

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Suppress binding warnings. #1025

merged 1 commit into from
Oct 25, 2024

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Oct 24, 2024

Suppress the warnings emitted by generator by default. These 19K+ warnings are clearly not things that we intend to take action on, and hide warnings we might want to take action on.

This is controlled via the $(_AndroidIgnoreGeneratorWarnings) property.

If seeing these warnings is desired on a local build, either:

  • Change $(_AndroidIgnoreGeneratorWarnings) to false in the Directory.Build.props file.
  • Pass it as a build property:
    • dotnet build -p:_AndroidIgnoreGeneratorWarnings=false

Also fix some IsTrimmable warnings by not enabling it on netstandard2.0 projects.

@jpobst jpobst marked this pull request as ready for review October 24, 2024 23:13
@jpobst jpobst requested a review from moljac October 24, 2024 23:13
@jpobst jpobst merged commit ba25f01 into main Oct 25, 2024
6 checks passed
@jpobst jpobst deleted the suppress-warnings branch October 25, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants