[guava] update Guava dependencies #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: xamarin/XamarinComponents#1312 Context: xamarin/XamarinComponents@0874b32 Context: https://www.nuget.org/packages/Xamarin.Google.Guava.FailureAccess/1.0.1.5 Context: https://www.nuget.org/packages/Xamarin.Google.Guava.ListenableFuture/1.0.0.5 If you do: $ mkdir foo ; cd foo $ dotnet new mauilib $ dotnet pack You end up redistributing `com.google.common.util.concurrent.ListenableFuture` in your MAUI class library NuGet package: * `foo.1.0.0.nupkg` * `lib\net6.0-android31.0\foo.aar` * `libs\78C2212B1AE12Ed.jar` * `com\google\common\util\concurrent\ListenableFuture.class` This was fixed in XamarinComponents and pushed to NuGet.org, but we need to update the AndroidX dependencies for the new versions.
moljac
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: xamarin/XamarinComponents#1312
Context: xamarin/XamarinComponents@0874b32
Context: https://www.nuget.org/packages/Xamarin.Google.Guava.FailureAccess/1.0.1.5
Context: https://www.nuget.org/packages/Xamarin.Google.Guava.ListenableFuture/1.0.0.5
If you do:
You end up redistributing
com.google.common.util.concurrent.ListenableFuturein your MAUI class library NuGet package:
foo.1.0.0.nupkglib\net6.0-android31.0\foo.aarlibs\78C2212B1AE12Ed.jarcom\google\common\util\concurrent\ListenableFuture.classThis was fixed in XamarinComponents and pushed to NuGet.org, but we
need to update the AndroidX dependencies for the new versions.