Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

GH-272 Fix Null Exception on Location Updates #276

Merged
merged 2 commits into from
Jun 4, 2018
Merged

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Check for null :)

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

API Changes

Changed:
Ensure on each platform that null is checked.

Added helpers on UWP to simplify things.

Behavioral Changes

Describe any non-bug related behavioral changes that may change how users app behaves when upgrading to this version of the codebase.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno requested a review from Redth June 4, 2018 16:56
@dend
Copy link
Contributor

dend commented Jun 4, 2018

✅ Validation status: passed

File Status Preview URL Details
Xamarin.Essentials/Geolocation/Geolocation.android.cs ✅Succeeded
Xamarin.Essentials/Geolocation/Geolocation.ios.cs ✅Succeeded
Xamarin.Essentials/Geolocation/Geolocation.uwp.cs ✅Succeeded
Xamarin.Essentials/Types/LocationExtensions.uwp.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@mattleibow mattleibow merged commit 35a418e into master Jun 4, 2018
@mattleibow mattleibow deleted the bug/issues-272 branch June 4, 2018 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants