Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

GH-450 Browser - Fix for authority to make sure we get the port. #452

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

jamesmontemagno
Copy link
Collaborator

Description of Change

Make sure we use Authority. Via: https://stackoverflow.com/questions/2142910/whats-the-difference-between-uri-host-and-uri-authority

Authority = Host Name + Port No

And if URL protocol is using a default port, say port 80 for http URL, then only in that case Authority = Host Name (Port No is assumed to be 80),

Whereas Host Name is either Domain Name or I.P Address

Example:

http://www.example.com/

Authority = www.example.com
Host Name = www.example.com

http://255.255.255.255:8080/

Authority = 255.255.255.255:8080
Host Name = 255.255.255.255

Bugs Fixed

Provide links to issues here. Ensure that a GitHub issue was created for your feature or bug fix before sending PR.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

@jamesmontemagno jamesmontemagno added the awaiting-review This PR needs to have a set of eyes on it label Aug 6, 2018
@jamesmontemagno jamesmontemagno added this to the 0.10.0-preview milestone Aug 6, 2018
@jamesmontemagno jamesmontemagno requested a review from Redth August 6, 2018 22:58
@dend
Copy link
Contributor

dend commented Aug 6, 2018

✅ Validation status: passed

File Status Preview URL Details
Tests/Browser_Tests.cs ✅Succeeded
Xamarin.Essentials/Browser/Browser.shared.cs ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Redth Redth merged commit e6f925e into master Aug 14, 2018
@Redth Redth deleted the bug/issue-450 branch August 14, 2018 17:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
awaiting-review This PR needs to have a set of eyes on it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants