GH-643: Add Android P targeting and support 28 support

.github/PULL_REQUEST_TEMPLATE.md

@@ -14,12 +14,22 @@ List all API changes here (or just put None), example:
 
 Added: 
 
-- string - string Class.Property { get; set; } 
-- void Class.Method();
+- `string Class.Property { get; set; }`
+- `void Class.Method();`
 
 Changed:
 
- - object Cell.OldPropertyName => object Cell.NewPropertyName
+ - `object Cell.OldPropertyName` => `object Cell.NewPropertyName`
+
+If there is an entirely new API, then you can use a more verbose style:
+
+```csharp
+public static class NewClass {
+    public static int SomeProperty { get; set; }
+    public static void SomeMethod(string value);
+}
+```
+
 
 ### Behavioral Changes ###
 

DeviceTests/DeviceTests.Android/DeviceTests.Android.csproj

@@ -75,14 +75,14 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
-    <PackageReference Include="Xamarin.Android.Support.Design" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v4" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="27.0.2.1" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
+    <PackageReference Include="Xamarin.Android.Support.Design" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v4" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="28.0.0.1" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.devices" Version="2.5.20" />

DeviceTests/DeviceTests.Shared/DeviceTests.Shared.csproj

@@ -32,9 +32,9 @@
     <DebugType>pdbonly</DebugType>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="MSBuild.Sdk.Extras" Version="1.6.60" PrivateAssets="All" />
+    <PackageReference Include="MSBuild.Sdk.Extras" Version="1.6.61" PrivateAssets="All" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.devices" Version="2.3.3" />
     <PackageReference Include="UnitTests.HeadlessRunner" Version="2.0.0" />
@@ -48,13 +48,13 @@
     </SDKReference>
   </ItemGroup>
   <ItemGroup Condition=" $(TargetFramework.StartsWith('MonoAndroid')) ">
-    <PackageReference Include="Xamarin.Android.Support.Design" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v4" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="27.0.2.1" />
+    <PackageReference Include="Xamarin.Android.Support.Design" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v4" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="28.0.0.1" />
     <Reference Include="System.Numerics" />
     <Reference Include="System.Numerics.Vectors" />
   </ItemGroup>

DeviceTests/DeviceTests.UWP/DeviceTests.UWP.csproj

@@ -127,7 +127,7 @@
   </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="UnitTests.HeadlessRunner" Version="2.0.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.1.9" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.devices" Version="2.3.3" />

DeviceTests/DeviceTests.iOS/DeviceTests.iOS.csproj

@@ -133,7 +133,7 @@
     <Reference Include="Xamarin.iOS" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="xunit" Version="2.4.1" />
     <PackageReference Include="xunit.runner.devices" Version="2.5.20" />
     <PackageReference Include="UnitTests.HeadlessRunner" Version="2.0.0" />

README.md

@@ -92,7 +92,7 @@ If building on Visual Studio 2017, you will need the following SDKs and workload
 
 ### You will need the following SDKs
 
-* Android 8.1 SDK Installed
+* Android 9.0, 8.1, 8.0, 7.1, 7.0, & 6.0 SDK Installed
 * UWP 10.0.16299 SDK Installed
 
 If using Visual Studio for Mac the project can be built at the command line with MSBuild. To change the project type that you are working with, simply edit Xamarin.Essentials.csproj and modify the TargetFrameworks for only the project type you want to use.

Samples/Samples.Android/Samples.Android.csproj

@@ -85,18 +85,18 @@
     <Reference Include="System.Xml" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.AppCenter" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.10.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
-    <PackageReference Include="Xamarin.Android.Support.Design" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v4" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="27.0.2.1" />
-    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="27.0.2.1" />
+    <PackageReference Include="Microsoft.AppCenter" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.13.0" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
+    <PackageReference Include="Xamarin.Android.Support.Design" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.AppCompat" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v4" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.CardView" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.v7.MediaRouter" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.CustomTabs" Version="28.0.0.1" />
+    <PackageReference Include="Xamarin.Android.Support.Core.Utils" Version="28.0.0.1" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
   </ItemGroup>
   <ItemGroup>

Samples/Samples.UWP/Samples.UWP.csproj

@@ -126,11 +126,11 @@
     <UseDotNetNativeToolchain>true</UseDotNetNativeToolchain>
   </PropertyGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.AppCenter" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.10.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Microsoft.AppCenter" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.13.0" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="Microsoft.NETCore.UniversalWindowsPlatform" Version="6.1.5" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
   </ItemGroup>

Samples/Samples.iOS/Samples.iOS.csproj

@@ -122,11 +122,11 @@
     <Reference Include="Xamarin.iOS" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.AppCenter" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.10.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Microsoft.AppCenter" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.13.0" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
   </ItemGroup>
   <ItemGroup>

Samples/Samples/Samples.csproj

@@ -23,11 +23,11 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AppCenter" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.10.0" />
-    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.10.0" />
-    <PackageReference Include="Xamarin.Forms" Version="3.3.0.967583" />
+    <PackageReference Include="Microsoft.AppCenter" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Analytics" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Crashes" Version="1.13.0" />
+    <PackageReference Include="Microsoft.AppCenter.Distribute" Version="1.13.0" />
+    <PackageReference Include="Xamarin.Forms" Version="3.5.0.129452" />
     <PackageReference Include="System.Numerics.Vectors" Version="4.5.0" />
   </ItemGroup>
 

Xamarin.Essentials/Browser/Browser.android.cs

@@ -22,7 +22,11 @@ static Task<bool> PlatformOpenAsync(Uri uri, BrowserLaunchMode launchMode)
                     var tabsIntent = tabsBuilder.Build();
                     tabsIntent.Intent.SetFlags(ActivityFlags.ClearTop);
                     tabsIntent.Intent.SetFlags(ActivityFlags.NewTask);
+#if __ANDROID_25__
                     tabsIntent.LaunchUrl(Platform.AppContext, nativeUri);
+#else
+                    tabsIntent.LaunchUrl(Platform.GetCurrentActivity(true), nativeUri);
+#endif
                     break;
                 case BrowserLaunchMode.External:
                     var intent = new Intent(Intent.ActionView, nativeUri);

Xamarin.Essentials/Connectivity/Connectivity.android.cs

@@ -18,7 +18,9 @@ static void StartListeners()
 
             conectivityReceiver = new ConnectivityBroadcastReceiver(OnConnectivityChanged);
 
+#pragma warning disable CS0618 // Type or member is obsolete
             Platform.AppContext.RegisterReceiver(conectivityReceiver, new IntentFilter(ConnectivityManager.ConnectivityAction));
+#pragma warning restore CS0618 // Type or member is obsolete
         }
 
         static void StopListeners()
@@ -64,7 +66,9 @@ static NetworkAccess PlatformNetworkAccess
 
                                 var info = manager.GetNetworkInfo(network);
 
+#pragma warning disable CS0618 // Type or member is obsolete
                                 if (info == null || !info.IsAvailable)
+#pragma warning restore CS0618 // Type or member is obsolete
                                     continue;
 
                                 // Check to see if it has the internet capability
@@ -95,12 +99,16 @@ static NetworkAccess PlatformNetworkAccess
 
                     void ProcessNetworkInfo(NetworkInfo info)
                     {
+#pragma warning disable CS0618 // Type or member is obsolete
                         if (info == null || !info.IsAvailable)
+#pragma warning restore CS0618 // Type or member is obsolete
                             return;
 
                         if (info.IsConnected)
                             currentAccess = IsBetterAccess(currentAccess, NetworkAccess.Internet);
+#pragma warning disable CS0618 // Type or member is obsolete
                         else if (info.IsConnectedOrConnecting)
+#pragma warning restore CS0618 // Type or member is obsolete
                             currentAccess = IsBetterAccess(currentAccess, NetworkAccess.ConstrainedInternet);
                     }
 
@@ -154,10 +162,12 @@ static IEnumerable<ConnectionProfile> PlatformConnectionProfiles
 
                 ConnectionProfile? ProcessNetworkInfo(NetworkInfo info)
                 {
+#pragma warning disable CS0618 // Type or member is obsolete
                     if (info == null || !info.IsAvailable || !info.IsConnectedOrConnecting)
                         return null;
 
                     return GetConnectionType(info.Type, info.TypeName);
+#pragma warning restore CS0618 // Type or member is obsolete
                 }
             }
         }
@@ -219,7 +229,9 @@ public ConnectivityBroadcastReceiver(Action onChanged) =>
 
         public override async void OnReceive(Context context, Intent intent)
         {
+#pragma warning disable CS0618 // Type or member is obsolete
             if (intent.Action != ConnectivityManager.ConnectivityAction)
+#pragma warning restore CS0618 // Type or member is obsolete
                 return;
 
             // await 500ms to ensure that the the connection manager updates

Xamarin.Essentials/Email/Email.android.cs

@@ -34,11 +34,13 @@ static Intent CreateIntent(EmailMessage message)
                 if (message?.BodyFormat == EmailBodyFormat.Html)
                 {
                     ISpanned html;
-                    if (Platform.HasApiLevel(BuildVersionCodes.N))
+#if __ANDROID_24__
+                    if (Platform.HasApiLevelN)
                     {
                         html = Html.FromHtml(message.Body, FromHtmlOptions.ModeLegacy);
                     }
                     else
+#endif
                     {
 #pragma warning disable CS0618 // Type or member is obsolete
                         html = Html.FromHtml(message.Body);

Xamarin.Essentials/PhoneDialer/PhoneDialer.android.cs

@@ -26,9 +26,14 @@ static void PlatformOpen(string number)
             ValidateOpen(number);
 
             var phoneNumber = string.Empty;
-            if (Platform.HasApiLevel(BuildVersionCodes.N))
+#if __ANDROID_24__
+            if (Platform.HasApiLevelN)
                 phoneNumber = PhoneNumberUtils.FormatNumber(number, Java.Util.Locale.GetDefault(Java.Util.Locale.Category.Format).Country);
             else if (Platform.HasApiLevel(BuildVersionCodes.Lollipop))
+#else
+            if (Platform.HasApiLevel(BuildVersionCodes.Lollipop))
+#endif
+
                 phoneNumber = PhoneNumberUtils.FormatNumber(number, Java.Util.Locale.Default.Country);
             else
 #pragma warning disable CS0618

Xamarin.Essentials/Platform/Platform.android.cs

@@ -61,6 +61,41 @@ internal static bool IsIntentSupported(Intent intent)
             return activities.Any();
         }
 
+        internal static bool HasApiLevelN =>
+#if __ANDROID_24__
+            HasApiLevel(BuildVersionCodes.N);
+#else
+            false;
+#endif
+
+        internal static bool HasApiLevelNMr1 =>
+#if __ANDROID_25__
+        HasApiLevel(BuildVersionCodes.NMr1);
+#else
+        false;
+#endif
+
+        internal static bool HasApiLevelO =>
+#if __ANDROID_26__
+            HasApiLevel(BuildVersionCodes.O);
+#else
+            false;
+#endif
+
+        internal static bool HasApiLevelOMr1 =>
+#if __ANDROID_27__
+            HasApiLevel(BuildVersionCodes.OMr1);
+#else
+            false;
+#endif
+
+        internal static bool HasApiLevelP =>
+#if __ANDROID_28__
+            HasApiLevel(BuildVersionCodes.P);
+#else
+            false;
+#endif
+
         internal static bool HasApiLevel(BuildVersionCodes versionCode) =>
             (int)Build.VERSION.SdkInt >= (int)versionCode;
 
@@ -92,8 +127,10 @@ internal static Java.Util.Locale GetLocale()
         {
             var resources = AppContext.Resources;
             var config = resources.Configuration;
-            if (HasApiLevel(BuildVersionCodes.N))
+#if __ANDROID_24__
+            if (HasApiLevelN)
                 return config.Locales.Get(0);
+#endif
 
             return config.Locale;
         }
@@ -103,7 +140,8 @@ internal static void SetLocale(Java.Util.Locale locale)
             Java.Util.Locale.Default = locale;
             var resources = AppContext.Resources;
             var config = resources.Configuration;
-            if (HasApiLevel(BuildVersionCodes.N))
+
+            if (HasApiLevelN)
                 config.SetLocale(locale);
             else
                 config.Locale = locale;

Xamarin.Essentials/Vibration/Vibration.android.cs

@@ -16,7 +16,7 @@ static void PlatformVibrate(TimeSpan duration)
 
             var time = (long)duration.TotalMilliseconds;
 #if __ANDROID_26__
-            if (Platform.HasApiLevel(BuildVersionCodes.O))
+            if (Platform.HasApiLevelO)
             {
                 Platform.Vibrator.Vibrate(VibrationEffect.CreateOneShot(time, VibrationEffect.DefaultAmplitude));
                 return;