Skip to content
This repository has been archived by the owner on May 15, 2024. It is now read-only.

GH-969 Clipboard Changed #720

Merged
merged 32 commits into from
Dec 19, 2019
Merged

Conversation

Mrnikbobjeff
Copy link
Contributor

@Mrnikbobjeff Mrnikbobjeff commented Feb 26, 2019

Description of Change

Added Clipboard Change Event

API Changes

Added:
On Clipboard

  • event ClipboardChangedEvent<EventArgs>

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Has samples (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Updated documentation (see walkthrough)

csdinon and others added 23 commits December 10, 2018 08:17
* Add extension helpers for iOS and Android

* Add UWP colors and adjsut android colors.

* Add UWP Point/Rect/Size

* Rename and optimize!

* Add tests and color helpers!

* Fix unit test and add WithAlpha

* Cleanup iOS as it stores it from 0-1

* Tests are all green!

* Add generate-docs cmd :)

* Add docs config to all :)

* Additional clenaup for docs

* Added some docs

* Updated the mdoc target and regenerated the docs
Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported.
* Implemented xamarinGH-196

* Apply suggestions from code review: Naming

Renamed incorrectly spelled variables

Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de>

* Implemented xamarinGH-196

* Browser update work as requested. Using System.Drawing.Color now

* Adopted more review changes. Type forwarded.

* Review changes

* Made equals operator null safe, removed constructor
…tion (xamarin#677)

* Added  bool IsFromMockProvider in Location class

* Checkin

* csproj original

* Revert "csproj original"

This reverts commit 6302b95.

* Revert "Checkin"

This reverts commit 0881e4f.

* Revert "Added  bool IsFromMockProvider in Location class"

This reverts commit e56d940.

* Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original;

Adjust the property IsFromMockProvider in Location.shared and LocationExetensions.

* Edited sample to show if the location is from moking provider.

* Update docs
* Update CONTRIBUTING.md (xamarin#692)

* xamarinGH-126 Detect Shake API (xamarin#666)

* Added shaken support

* name vhange

* check-in

* doc update

* Implements the Shake API inside Accelerometer Class;
Change sample to AccelorometerViewModel

* Fix the sample project

* Update the docs

* Added Queue mechanism based off seismic with tests as well. Something is not  right yet with calulating isaccelerating.

* Finalize shake detection!!!

* Re-generated the docs.

* Fix the VM after merge
* Update CONTRIBUTING.md (xamarin#692)

* xamarin#704 if we get a duplicate item try to remove and then re-add if possible.
… fixed other issues related to Visual Studio for Mac and Essentials support.
… fixed other issues related to Visual Studio for Mac and Essentials support.
@VSC-Service-Account

This comment has been minimized.

@VSC-Service-Account

This comment has been minimized.

@VSC-Service-Account

This comment has been minimized.

@Mrnikbobjeff
Copy link
Contributor Author

Sorry for the delay, had uni stuff coming up. This is basically finished and ready to be merged. I still need to update the docs tomorrow. Tested on Android&UWP, ios is so simple that I dont think i made a mistake there.

@VSC-Service-Account

This comment has been minimized.

@VSC-Service-Account

This comment has been minimized.

@VSC-Service-Account
Copy link

Docs Build status updates of commit cf9750a:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details
.openpublishing.publish.config.json ❌Error Details

  • Line 117: [Error] Restore nuget package W:\ko3d-s\.optemp\dependentPackages\Microsoft.DocAsCode.ECMA2Yaml\packages.config in folder:W:\ko3d-s\.optemp\packages failed, possibly due to transient errors from nuget servers. Please retry building your content. If the issue still happens, open a ticket in http://SiteHelp and include the build report and the following error message for our team to troubleshoot: Errors in packages.config projects Unable to find version '1.0.483' of package 'Microsoft.DocAsCode.ECMA2Yaml'. D:\Windows\system32\config\systemprofile\.nuget\packages\: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'D:\Windows\system32\config\systemprofile\.nuget\packages\'. https://www.myget.org/F/op/api/v2: Package 'Microsoft.DocAsCode.ECMA2Yaml.1.0.483' is not found on source 'https://www.myget.org/F/op/api/v2'.

.openpublishing.publish.config.json

  • Line 290: [Error] Restore of dependent packages failed. Please check your .openpublishing.publish.config.json?on the configuration of the dependent packages or ask for help?in Docs Support teams channel. Please also include the following error code for our team to troubleshoot: 1

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

Copy link
Contributor

@newky2k newky2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There doesn't appear to be any changes to the documentation relating to the new Clipboard API

@newky2k newky2k added DO-NOT-MERGE Don't merge it.... don't do it! needs-specifications Accepted feature/enhancement and needs specification. labels May 27, 2019
@jamesmontemagno jamesmontemagno added the community Community contributions label Aug 1, 2019
@VSC-Service-Account
Copy link

Docs Build status updates of commit b418f7b:

❌ Validation status: errors

Please follow instructions here which may help to resolve issue.

File Status Preview URL Details
❌Error Details

  • [Error] Cannot sync git repo to specified state. Please make sure the pull request is mergeable. Details: Git merge results in conflict, repository remote url: https://github.com/xamarin/Essentials, working directory: W:\ddzt-s, target branch: HEAD, target branch commit: ff6dd3edb157d12a7cbb6f13901f33e6bd9501ac, source commit: b418f7b8a7e6b4dcd2896ecb36d8f71af29dca60.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VSC-Service-Account
Copy link

Docs Build status updates of commit bfab86e:

⚠️ Validation status: warnings

File Status Preview URL Details
⚠️Warning Details
Samples/Samples/View/ClipboardPage.xaml ✅Succeeded
Samples/Samples/ViewModel/ClipboardViewModel.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.android.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.ios.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.netstandard.tvos.watchos.tizen.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.shared.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.uwp.cs ✅Succeeded
Xamarin.Essentials/Xamarin.Essentials.csproj ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Clipboard.xml ✅Succeeded
docs/en/index.xml ✅Succeeded

  • [Warning] Uid(Xamarin.Essentials.ColorExtensions.ToPlatformColor(System.Drawing.Color)_m) has already been defined in api/Xamarin.Essentials.ColorExtensions.ToPlatformColor.yml#Xamarin_Essentials_ColorExtensions_ToPlatformColor_System_Drawing_Color__m.
  • [Warning] Uid(Xamarin.Essentials.PointExtensions.ToPlatformPoint(System.Drawing.Point)_m) has already been defined in api/Xamarin.Essentials.PointExtensions.ToPlatformPoint.yml#Xamarin_Essentials_PointExtensions_ToPlatformPoint_System_Drawing_Point__m.
  • [Warning] Uid(Xamarin.Essentials.SizeExtensions.ToPlatformSize(System.Drawing.Size)_m) has already been defined in api/Xamarin.Essentials.SizeExtensions.ToPlatformSize.yml#Xamarin_Essentials_SizeExtensions_ToPlatformSize_System_Drawing_Size__m.
  • [Warning] Uid(Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle(System.Drawing.Rectangle)_m) has already been defined in api/Xamarin.Essentials.RectangleExtensions.ToPlatformRectangle.yml#Xamarin_Essentials_RectangleExtensions_ToPlatformRectangle_System_Drawing_Rectangle__m.

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VSC-Service-Account
Copy link

Docs Build status updates of commit 38138e4:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/ClipboardPage.xaml ✅Succeeded
Samples/Samples/ViewModel/ClipboardViewModel.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.android.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.ios.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.netstandard.tvos.watchos.tizen.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.shared.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.uwp.cs ✅Succeeded
Xamarin.Essentials/Xamarin.Essentials.csproj ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Clipboard.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@VSC-Service-Account
Copy link

Docs Build status updates of commit ec84740:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/ClipboardPage.xaml ✅Succeeded
Samples/Samples/ViewModel/ClipboardViewModel.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.android.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.ios.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.netstandard.tvos.watchos.tizen.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.shared.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Clipboard.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@Mrnikbobjeff
Copy link
Contributor Author

Docs are live, everything should be done. Android device tests should work if you restart them, they did not fault because of me.

Copy link
Collaborator

@jamesmontemagno jamesmontemagno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving and we should bring into a branch to clean up any final details :) Thanks for the work on this!

@VSC-Service-Account
Copy link

Docs Build status updates of commit fff26cf:

✅ Validation status: passed

File Status Preview URL Details
Samples/Samples/View/ClipboardPage.xaml ✅Succeeded
Samples/Samples/ViewModel/ClipboardViewModel.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.android.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.ios.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.netstandard.tvos.watchos.tizen.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.shared.cs ✅Succeeded
Xamarin.Essentials/Clipboard/Clipboard.uwp.cs ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-android.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-ios.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials-uwp.xml ✅Succeeded
docs/en/FrameworksIndex/xamarin-essentials.xml ✅Succeeded
docs/en/Xamarin.Essentials/Clipboard.xml ✅Succeeded

For more details, please refer to the build report.

Note: If you changed an existing file name or deleted a file, broken links in other files to the deleted or renamed file are listed only in the full build report.

@jamesmontemagno jamesmontemagno added ready-to-merge Review completed, Ready for API review and merge and removed DO-NOT-MERGE Don't merge it.... don't do it! community Community contributions needs-specifications Accepted feature/enhancement and needs specification. labels Dec 19, 2019
@jamesmontemagno jamesmontemagno merged commit 5b5617e into xamarin:master Dec 19, 2019
ScottBTR pushed a commit to builttoroam/Essentials that referenced this pull request Jan 22, 2020
* Use SharedPreferences.Editor.Apply when editing to force disk write to be asynchronous (xamarin#637)

* xamarinGH-182 Color/Point/Rect/Size Extension Converters (xamarin#651)

* Add extension helpers for iOS and Android

* Add UWP colors and adjsut android colors.

* Add UWP Point/Rect/Size

* Rename and optimize!

* Add tests and color helpers!

* Fix unit test and add WithAlpha

* Cleanup iOS as it stores it from 0-1

* Tests are all green!

* Add generate-docs cmd :)

* Add docs config to all :)

* Additional clenaup for docs

* Added some docs

* Updated the mdoc target and regenerated the docs

* Allow for code reuse on macOS (xamarin#665)

Even though macOS is not yet officially supported, it is nice to reuse this code. macOS is exactly the same, except for this single property not supported.

* xamarinGH-196 Browser Customization (xamarin#646)

* Implemented xamarinGH-196

* Apply suggestions from code review: Naming

Renamed incorrectly spelled variables

Co-Authored-By: Mrnikbobjeff <schillinik@yahoo.de>

* Implemented xamarinGH-196

* Browser update work as requested. Using System.Drawing.Color now

* Adopted more review changes. Type forwarded.

* Review changes

* Made equals operator null safe, removed constructor

* Add documentation and simplify the API!

* Update viewmodel

* Back to 7.2

* xamarinGH-676 Require To Check GPS Location is Fake Or Not In GeoLocation (xamarin#677)

* Added  bool IsFromMockProvider in Location class

* Checkin

* csproj original

* Revert "csproj original"

This reverts commit 6302b95.

* Revert "Checkin"

This reverts commit 0881e4f.

* Revert "Added  bool IsFromMockProvider in Location class"

This reverts commit e56d940.

* Revert the Xamarin.Essentials.csproj and Samples.Android.csproj to original;

Adjust the property IsFromMockProvider in Location.shared and LocationExetensions.

* Edited sample to show if the location is from moking provider.

* Update docs

* Fixes xamarin#694 (xamarin#699)

* Update the mdoc to use the new minimum for VS2019

* xamarinGH-126: Finish Shake Detector API (xamarin#693)

* Update CONTRIBUTING.md (xamarin#692)

* xamarinGH-126 Detect Shake API (xamarin#666)

* Added shaken support

* name vhange

* check-in

* doc update

* Implements the Shake API inside Accelerometer Class;
Change sample to AccelorometerViewModel

* Fix the sample project

* Update the docs

* Added Queue mechanism based off seismic with tests as well. Something is not  right yet with calulating isaccelerating.

* Finalize shake detection!!!

* Re-generated the docs.

* Fix the VM after merge

* xamarinGH-704 Handle duplicate item in keychain (xamarin#705)

* Update CONTRIBUTING.md (xamarin#692)

* xamarin#704 if we get a duplicate item try to remove and then re-add if possible.

* Initial commit Clipboard Change

* Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support.

* Initial commit Clipboard Change

* Implemented Clipboard listeners on iOS, tested on android and uwp and fixed other issues related to Visual Studio for Mac and Essentials support.

* Naming fix

* UI improvements

* Docs update

* docs update part 2

* docs tool breaking fix

* reverted change to csproj
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ready-to-merge Review completed, Ready for API review and merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants