Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Bug] IndicatorView isn't rendering indicators #12028

Closed
davidortinau opened this issue Sep 4, 2020 · 4 comments · Fixed by #12654
Closed

[Bug] IndicatorView isn't rendering indicators #12028

davidortinau opened this issue Sep 4, 2020 · 4 comments · Fixed by #12654
Assignees
Labels
a/indicatorview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/5 🕔 5 iOS 14 p/iOS 🍎 t/bug 🐛
Milestone

Comments

@davidortinau
Copy link
Contributor

Description

I'm not seeing any indicators. Perhaps an iOS 14 related thing. I verified the IndicatorView is present.

Simulator Screen Shot - iPhone 11 Pro - 2020-09-04 at 15 51 00

<StackLayout Margin="15" Spacing="10">
            <Frame BackgroundColor="White"
                   Padding="10"
                   BorderColor="Black"
                   CornerRadius="0">
                <CarouselView x:Name="reiCV"
                              IndicatorView="indicatorView"
                              HeightRequest="160">
                    <CarouselView.ItemsSource>
                        <x:Array Type="{x:Type x:String}">
                            <x:String>h01.png</x:String>
                            <x:String>h02.png</x:String>
                            <x:String>h03.png</x:String>
                            <x:String>h04.png</x:String>
                        </x:Array>
                    </CarouselView.ItemsSource>
                    <CarouselView.ItemTemplate>
                        <DataTemplate>
                            <Image Source="{Binding .}"/>
                        </DataTemplate>
                    </CarouselView.ItemTemplate>
                </CarouselView>
            </Frame>

            <IndicatorView 
                IndicatorColor="LightGray"
                SelectedIndicatorColor="Black"
                IndicatorSize="10"
                HorizontalOptions="Center"
                x:Name="indicatorView"/>
            
        </StackLayout>

Basic Information

  • Version with issue: 5.0.0.4865 (build from latest valid commit on that branch)
  • Platform Target Frameworks:
    • iOS: iOS 14 using preview 2 of Xamarin.iOS

Reproduction Link

https://github.com/davidortinau/CarouselGallery

Several examples use IndicatorView. None of them work properly.

@davidortinau davidortinau added t/bug 🐛 s/unverified New report that has yet to be verified a/indicatorview labels Sep 4, 2020
@davidortinau davidortinau added this to the 5.0.0 milestone Sep 4, 2020
@hartez hartez added e/5 🕔 5 iOS 14 p/iOS 🍎 and removed s/unverified New report that has yet to be verified labels Sep 5, 2020
@TiagoPicao-V23437
Copy link

I was able to show custom indicators through IndicatorTemplate. Created a frame with rounded corners to mimic a round indicator.

@PawKanarek
Copy link
Contributor

@TiagoPicao-V23437 can you share your code with custom indicator template? I have the same issue with missing indicators iOS 14. And i've tied to make some custom template like you said, but my frame with rounded corners is as big as 40px, even if i said it height/width request should be 5px...

@samhouts samhouts modified the milestones: 5.0.0, 4.8.0 Sep 30, 2020
@TiagoPicao-V23437
Copy link

TiagoPicao-V23437 commented Oct 1, 2020

@PawKanarek I did have to tinker a little bit with (and on another screen again due to different layout), but this was working on a very simple layout:

<IndicatorView.IndicatorTemplate> <DataTemplate> <Frame HasShadow="False" Padding="3" HeightRequest="3" WidthRequest="3"> <Frame.CornerRadius> <OnPlatform x:TypeArguments="x:Single"> <On Platform="iOS" Value="5"></On> <On Platform="Android" Value="10"></On> </OnPlatform> </Frame.CornerRadius> </Frame> </DataTemplate> </IndicatorView.IndicatorTemplate>

I think it was adding some padding that helped.

@Tommigun1980
Copy link

Is this a duplicate of #12318 ?

@davidortinau davidortinau added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Oct 6, 2020
@davidortinau davidortinau modified the milestones: 4.8.0, 5.0.0 Oct 6, 2020
@jsuarezruiz jsuarezruiz self-assigned this Oct 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/indicatorview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. e/5 🕔 5 iOS 14 p/iOS 🍎 t/bug 🐛
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants