Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Spec] APIS That need to be made public for contributors and Xamarin Community Tookit #12136

Closed
PureWeen opened this issue Sep 16, 2020 · 6 comments · Fixed by #12623
Closed
Assignees
Labels
5.0.0-pre4 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. in-progress This issue has an associated pull request that may resolve it! t/enhancement ➕

Comments

@PureWeen
Copy link
Contributor

As we move controls over to the XCT we need to expose some properties to the outside world

Here's the list so far. As we create issues to fix these please link them here

Internal

  • Binding.SelfPath constant
  • GestureRecognizer default ctor
  • NullEffect class
    Private
  • FontElement class
  • PaddingElement class

Xamarin.Forms.Core.UnitTests:
Internal:

  • RelativeLayoutTests.UnitExpressionSearch class

In addition, the Markup unit tests use reflection to access these private API's in Xamarin.Forms.Core in the BindableObject class: GetContext method, BindableContextAttributes enum , BindablePropertyContext nested class , SetValueArgs nested class

@VincentH-Net
Copy link
Contributor

VincentH-Net commented Sep 16, 2020

Thanks for creating this issue @PureWeen;

Most of the listed API's are used by C# Markup. Once these API's are available in the XCT we can move C# Markup there.

@SkyeHoefling
Copy link
Contributor

As I work through migrating the Popup Control (xamarin/XamarinCommunityToolkit#292) I will document some of the APIs required that are currently internal. Right, now I have created the referenced PR #12125 to allow protected constructor for VisualElement. I know UWP is already giving me some issues and I'll document those here.

@pictos
Copy link
Contributor

pictos commented Sep 16, 2020

@PureWeen would be good to have the PlatformSpecific bits public as well. Even if they are decorated with EditorBrowsable.Never attribute.
please see:
https://github.com/jfversluis/XamarinCommunityToolkit-1/commit/faf782d8d28193c3f3764505022fda1ce9ffde3c#commitcomment-41827281

@PureWeen PureWeen added this to the Xamarin Community Toolkit milestone Sep 17, 2020
@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. and removed proposal-open labels Sep 17, 2020
@SkyeHoefling
Copy link
Contributor

I just submitted 2 PRs that open up several APIs for iOS/UWP that are required to complete the Popup Control port from Xamarin.Forms to the Xamarin Community Toolkit. Once those are merged I will be very close to finishing up my work on the Popup Control

@Redth
Copy link
Member

Redth commented Oct 26, 2020

@StephaneDelcroix can you weigh in here?

@VincentH-Net
Copy link
Contributor

VincentH-Net commented Oct 29, 2020

@PureWeen could you add the internal IPaddingElement interface to the issue description?
C# Markup also needs to access that one.
I missed it earlier (my bad). I already added it in the corresponding XCT issue
Thx!

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0.0-pre4 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. in-progress This issue has an associated pull request that may resolve it! t/enhancement ➕
Projects
None yet
7 participants