Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Change Accessors for UWP Specific APIs to public [Xamarin Community Toolkit] #12279

Closed

Conversation

SkyeHoefling
Copy link
Contributor

Description of Change

Changed accessor modifier for several UWP APIs from internal to public. This is required as part of the Xamarin Community Toolkit implementation of the Popup control.

Related to xamarin/XamarinCommunityToolkit#292

Issues Resolved

API Changes

Changed:
Platform.cs

  • internal static Platform Current => public static Platform Current

VisualElementExtensions.cs

  • internal static void Cleanup => public static void Cleanup

PageExtensions.cs

  • internal static FrameworkElement ToFrameworkElement => public static FrameworkElement ToFrameworkElement

Platforms Affected

  • UWP

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Not applicable

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

Copy link
Contributor

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahoefling These methods are all pretty unexciting

Can you just copy the behavior of these into essentials?

Aspects of these might need to change inside forms so just a little bit worried about opening them up.

FYI @jfversluis @jsuarezruiz

@PureWeen PureWeen added blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. 5.0.0-pre4 labels Oct 29, 2020
@SkyeHoefling
Copy link
Contributor Author

I've been chatting with @PureWeen about this PR and everything I requested to be opened up for the Xamarin Community Toolkit can be re-implemented or use another strategy to get Popups working in UWP.

I don't need this merged and I am going to close the PR

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
5.0.0-pre4 blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/UWP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants