Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Enhancement] Upgrade for Xamarin.Forms maps #12504

Closed
LamijaV opened this issue Oct 16, 2020 · 7 comments · Fixed by #12520
Closed

[Enhancement] Upgrade for Xamarin.Forms maps #12504

LamijaV opened this issue Oct 16, 2020 · 7 comments · Fixed by #12520
Assignees
Labels
in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕

Comments

@LamijaV
Copy link

LamijaV commented Oct 16, 2020

Hi, I see that the latest version of Xamarin.Forms maps is still dependent of Xamarin.Android.Support.v4. When can we expect the upgrade for AndroidX (without support libraries)?

Additional: This is causing androidX issue when combined with one of our native libraries that is using AndroidX.
Thanks!
image

@mattleibow
Copy link
Contributor

This is very weird.

According to the logic, I am splitting on $... And it has to exist because I do a Contains($) before I do the split: https://github.com/xamarin/AndroidX/blob/master/source/migration/Migration/CecilMigrator.cs#L471-L472

Is it possible to attach a binlog so I can have a closer look? Or even a diagnostic log?

@rachelkang
Copy link
Contributor

^ also check your target framework and make sure you're running on Android API 28/29!

and @LamijaV to address your first point, we have a PR open for that (#10873) so you should see an upgrade soon enough :)

@rachelkang rachelkang added the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Oct 16, 2020
@LamijaV
Copy link
Author

LamijaV commented Oct 19, 2020

Hi Matt,

Here is the diagnostic output. More info on the project:
XF 4.7.0.1179
compiling and target Android 10.0 (Q)
Xamarin.AndroidX.Migration 10.0.6.1 (tried 1.0.7.1 as well)
native lib for contactless payment (containing visa and mastercard sdks) targeting android 10 and AndroidX

When I include maps I get this exception, when I remove it project build with no errors. When I build the project without this native lib but with maps it builds ok.

I had same issue with some other packages. I have not been able to detect exact cause but when upgrading them to newer versions that support AndroidX fully error disappears, and that is why I'm hoping upgrade of XF Maps will to :)

Please let me know if I can help you with more info.

diagnostics.txt

@LamijaV
Copy link
Author

LamijaV commented Oct 19, 2020

^ also check your target framework and make sure you're running on Android API 28/29!

and @LamijaV to address your first point, we have a PR open for that (#10873) so you should see an upgrade soon enough :)

Thanks! Looking forward to it.

@Redth Redth removed the s/needs-info ❓ A question has been asked that requires an answer before work can continue on this issue. label Oct 20, 2020
@rmarinho
Copy link
Member

rmarinho commented Nov 2, 2020

We have a PR for this : #12520

@rmarinho
Copy link
Member

rmarinho commented Nov 2, 2020

Actually maps were already updated and merged on #10873

@rmarinho rmarinho closed this as completed Nov 2, 2020
@LamijaV
Copy link
Author

LamijaV commented Nov 2, 2020

Awesome, thanks! @rmarinho do you maybe know when the new version with upgrade will be available?

@samhouts samhouts added the in-progress This issue has an associated pull request that may resolve it! label Nov 2, 2020
rmarinho added a commit that referenced this issue Nov 5, 2020
* [Android] Update AndroidX packages

* Update AndroidManifest.xml

* Update DualScreen.Android.csproj

* Update Xamarin.Forms.DualScreen.csproj

* [Android] Update Dualscreen  projects

* Update Xamarin.Forms.ControlGallery.Android.csproj

* [Android] Remove extra manifest

* Update build.cake

* [Nuspec] Update nuspecs

* - remove all support library references

Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
in-progress This issue has an associated pull request that may resolve it! proposal-open t/enhancement ➕
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants