This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[GH-10729] Added Current Page in Shell #10979
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@PureWeen opinion on this ? |
Definitely a very useful enhancement, it would be nice to have access to the PresentedPage and stop using workarounds like this: (Shell.Current?.CurrentItem?.CurrentItem as IShellSectionController)?.PresentedPage |
PureWeen
reviewed
Jul 17, 2020
@PureWeen, something else fixed that issue, the code works without the |
PureWeen
approved these changes
Jul 30, 2020
PureWeen
suggested changes
Aug 15, 2020
PureWeen
reviewed
Aug 27, 2020
PureWeen
approved these changes
Aug 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR provides an easy way to access the PresentedPage in Shell applications.
Issues Resolved
API Changes
Added:
Page Shell.CurrentPage { get; }
Shell : IPageContainer<Page>
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Create an AppShell, and access the
Shell.Current.CurrentPage
, its value should be the presented page. Also, I added some unit tests.PR Checklist