This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Disable animation scrolling to initial position in CarouselView #11173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why don't you just use |
jsuarezruiz
added
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Jun 23, 2020
jsuarezruiz
removed
the
DO-NOT-MERGE-!!! 🛑
This is in progress and needs to be updated before it can be merged.
label
Jun 24, 2020
Added |
samhouts
added
the
API-change
Heads-up to reviewers that this PR may contain an API change
label
Jul 8, 2020
samhouts
added
the
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
label
Aug 4, 2020
jsuarezruiz
force-pushed
the
fix-11081
branch
from
September 17, 2020 13:54
a5f7ee7
to
030948a
Compare
jsuarezruiz
removed
the
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
label
Sep 17, 2020
Retarget to 5.0.0 |
@rmarinho Previously, a new bool property was added to the |
samhouts
added
the
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
label
Sep 17, 2020
rmarinho
approved these changes
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/carouselview
a/collectionview
API-change
Heads-up to reviewers that this PR may contain an API change
Core
p/Android
p/iOS 🍎
p/UWP
retarget-branch-required
PR or associated issues target a milestone. Please target this PR to the matching branch.
t/bug 🐛
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Disable animation scrolling to initial position in CarouselView. With a high number of items, the time to complete the animation is noticeable.
Issues Resolved
API Changes
Added
AnimateInitialPosition
property toCarouselView
.Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Launch Core Gallery and navigate to the issue 11081. If the selected Item is the Item 2, directly without animations, the test has passed.
PR Checklist