Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android, iOS] Fix issue using ArcSegment to create a Path #11195

Merged
merged 15 commits into from
Aug 24, 2020
Merged

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

The issue was in the calculations for flatten an arc. Fixed:

  • Crash on iOS.
  • Rendering issue on Android and iOS.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

fix111190-ios

fix11190-droid

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added t/bug 🐛 p/iOS 🍎 p/Android p/macOS i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often a/shapes labels Jun 25, 2020
@samhouts samhouts added the Core label Jun 25, 2020
@StephaneDelcroix StephaneDelcroix changed the base branch from 4.7.0 to 4.8.0 July 23, 2020 07:24
@StephaneDelcroix
Copy link
Member

I retargeted this to 4.8. please fix the conflicts :)

@samhouts samhouts changed the base branch from 4.8.0 to 5.0.0 August 4, 2020 22:10
@samhouts samhouts added this to the 5.0.0 milestone Aug 4, 2020
@samhouts samhouts merged commit ea9c15e into 5.0.0 Aug 24, 2020
@samhouts samhouts deleted the fix-11190 branch August 24, 2020 21:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/shapes Core i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often p/Android p/iOS 🍎 p/macOS t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants