This repository has been archived by the owner on May 1, 2024. It is now read-only.
Added a Flow Direction Property to action sheets and alert dialogs #11679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
changed the title
samhouts
added
Core
p/Android
p/UWP
a/alerts
a/rtl
proposal-accepted
t/enhancement ➕
labels
hartez
suggested changes
Aug 7, 2020
Comment on lines
568
to
590
| if (options.FlowDirection == FlowDirection.MatchParent) | ||
| { | ||
| if (sender.FlowDirection == FlowDirection.RightToLeft) | ||
| options.FlowDirection = FlowDirection.RightToLeft; | ||
| else if (sender.FlowDirection == FlowDirection.LeftToRight) | ||
| options.FlowDirection = FlowDirection.LeftToRight; | ||
| else | ||
| { | ||
| if (Device.FlowDirection == FlowDirection.RightToLeft) | ||
| options.FlowDirection = FlowDirection.RightToLeft; | ||
| else if (Device.FlowDirection == FlowDirection.LeftToRight) | ||
| options.FlowDirection = FlowDirection.LeftToRight; | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of checking the FlowDirection values for the Page (and then the Device) here, I think you can just use the Page's EffectiveFlowDirection - it should already be set to either RightToLeft or LeftToRight (depending on its FlowDirection settings.
Comment on lines
145
to
167
| if (sender.FlowDirection == FlowDirection.LeftToRight) | ||
| { | ||
| layoutDirection = LayoutDirection.Ltr; | ||
| textDirection = TextDirection.Ltr; | ||
| } | ||
| else if (sender.FlowDirection == FlowDirection.RightToLeft) | ||
| { | ||
| layoutDirection = LayoutDirection.Rtl; | ||
| textDirection = TextDirection.Rtl; | ||
| } | ||
| else | ||
| { | ||
| if (Device.FlowDirection == FlowDirection.LeftToRight) | ||
| { | ||
| layoutDirection = LayoutDirection.Ltr; | ||
| textDirection = TextDirection.Ltr; | ||
| } | ||
| else if (Device.FlowDirection == FlowDirection.RightToLeft) | ||
| { | ||
| layoutDirection = LayoutDirection.Rtl; | ||
| textDirection = TextDirection.Rtl; | ||
| } | ||
| } |
There was a problem hiding this comment.
Same thing as the UWP implementation - I think you can just look at the Page's EffectiveFlowDirection here instead of having to check for each possible setting of FlowDirection.
samhouts
added
the
API-change
PureWeen
suggested changes
Aug 12, 2020
Xamarin.Forms.Controls.Issues/Xamarin.Forms.Controls.Issues.Shared/Issue2448.xaml.cs
Outdated
Show resolved
Hide resolved
hartez
approved these changes
Oct 29, 2020
rmarinho
added
the
blocker
jsuarezruiz
approved these changes
Dec 3, 2020
pictos
pushed a commit
to pictos/Xamarin.Forms
that referenced
this pull request
Dec 30, 2020
…amarin#11679) * added constructor actionsheet * added flow direction to action sheets on Android * added flow direction to alerts on Android * added Android alert dialog flow direction * UWP alert/actionsheet flow direction * add alert dialog flow direction * added flow direction to UWP alert and actionsheets * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * fixes xamarin#2448 * Fix rebase errors * - fix rebase Co-authored-by: E.Z. Hart <hartez@gmail.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added a Flow Direction Property to action sheets and alert dialogs. Also, changed the default flow direction of action sheets and alert dialogs to follow the page's effective flow direction.
Issues Resolved
API Changes
Added:
Platforms Affected
Behavioral/Visual Changes
The action sheets and alert dialogs may change depending on the flow direction of the parent page.
Before/After Screenshots
Before (no flow direction):
After (RTL flow direction):
Testing Procedure
Create an alert dialog and action sheet on Android and UWP and set the FlowDirection property to right-to-left and left-to-right to see if the alert dialog and actions sheet follows the flow direction properly. Also, can play around with changing the phone culture to right-to-left and left-to-right languages and see if the default flow direction of the alerts and action sheets follow the phone setting properly.
PR Checklist