This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Core] Notify changes in a GradientStop (Color, Offset) #11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BretJohnson
reviewed
Aug 17, 2020
There was a problem hiding this comment.
FYI WPF apparently handles these scenarios by having a generic Changed notification on Freezables, sent whenever the object itself or anything underneath it changes. https://docs.microsoft.com/en-us/dotnet/framework/wpf/advanced/freezable-objects-overview
Maybe we should consider something similar (now or in the future), that's a more generic change notification mechanism.
samhouts
approved these changes
Aug 24, 2020
samhouts
added
retarget-branch-required
rmarinho
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Detect GradientStop changes and update the Brush.
Fixes
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Testing Procedure
Launch Core Gallery and navigate to the brushes gallery. Select the Gallery "Update Brush Colors Gallery" and tap the "Update Colors" Button. If the GradientBrush is updated, the test has passed.
PR Checklist