Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Core] Added RoundRectangleGeometry #11851

Merged
merged 4 commits into from
Sep 18, 2020
Merged

[Core] Added RoundRectangleGeometry #11851

merged 4 commits into from
Sep 18, 2020

Conversation

jsuarezruiz
Copy link
Contributor

@jsuarezruiz jsuarezruiz commented Aug 19, 2020 •
edited
Loading

Description of Change

Added RoundRectangleGeometry Geometry.

Issues Resolved

API Changes

Added RoundRectangleGeometry.

<Image
    Source="crimson.jpg">
    <Image.Clip>
        <RoundRectangleGeometry
            CornerRadius="12"
            Rect="0, 0, 150, 150"/>
    </Image.Clip>
</Image>

Platforms Affected

  • Core/XAML (all platforms)
  • iOS
  • Android
  • macOS

Behavioral/Visual Changes

None

Before/After Screenshots

clip-cornerradius

Testing Procedure

Launch Core Gallery and navigate to the shapes gallery. Select the "Clip CornerRadius Gallery", modify the corner radius and verify that everything works as expected.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@haavamoa
Copy link

Goodbye PancakeView ❤️

hartez
hartez suggested changes Aug 24, 2020
View reviewed changes
Copy link
Contributor

@hartez hartez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs a formatting pass to fix the spaces/tabs.

Xamarin.Forms.Core/Shapes/GeometryGroup.cs Show resolved Hide resolved
Xamarin.Forms.Core/Shapes/LineGeometry.cs Show resolved Hide resolved
samhouts
samhouts approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@samhouts samhouts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with formatting changes

@samhouts
Copy link
Member

@jsuarezruiz please address formatting and conflicts! thanks!

@rmarinho
Copy link
Member

rmarinho commented Sep 8, 2020

@jsuarezruiz the formatting is still using spaces.

@samhouts samhouts merged commit d79d5b7 into 5.0.0 Sep 18, 2020
@samhouts samhouts deleted the roundrectanglegeometry branch September 18, 2020 21:36
@samhouts samhouts added this to the 5.0.0 milestone Sep 19, 2020
@jsuarezruiz jsuarezruiz removed the p/UWP label Sep 24, 2020
@YZahringer YZahringer mentioned this pull request Nov 8, 2020
Closed
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez requested changes

@samhouts samhouts samhouts approved these changes

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner

Assignees

@hartez hartez

@samhouts samhouts

Labels
a/shapes ControlGallery Core m/high impact ⬛ p/Android p/iOS 🍎 p/macOS p/WPF proposal-open t/enhancement ➕
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Enhancement] Support corner radius on RectangleGeometry
5 participants
@jsuarezruiz @haavamoa @samhouts @rmarinho @hartez