This repository has been archived by the owner on May 1, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
[Core,iOS,Droid,UWP,Tizen] Remove MediaElement #12007
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think MediaSource needs to go, too. |
I think below files need to go, too. (for Tizen)
|
StephaneDelcroix
approved these changes
Sep 8, 2020
samhouts
added
the
approved
Has two approvals, no pending reviews, and no changes requested
label
Sep 8, 2020
jsuarezruiz
suggested changes
Sep 9, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We almost have it!. But there are some pending lines to remove:
- In ControlGallery in UWP, Tizen and iOS. Example: https://github.com/xamarin/Xamarin.Forms/blob/remove-mediaelement/Xamarin.Forms.ControlGallery.WindowsUniversal/App.xaml.cs#L74
- From AssemblyInfo in Xamarin.Forms.Platform.Android.
jsuarezruiz
approved these changes
Sep 10, 2020
samhouts
added
a/mediaelement
breaking
Changes behavior or appearance
API-change
Heads-up to reviewers that this PR may contain an API change
deprecation
Public API has been deprecated
m/high impact ⬛
proposal-open
t/enhancement ➕
roadmap
labels
Sep 22, 2020
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a/mediaelement
API-change
Heads-up to reviewers that this PR may contain an API change
approved
Has two approvals, no pending reviews, and no changes requested
breaking
Changes behavior or appearance
ControlGallery
deprecation
Public API has been deprecated
m/high impact ⬛
p/Android
p/iOS 🍎
p/Tizen
p/UWP
p/WPF
proposal-open
roadmap
t/enhancement ➕
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Remove MediaElement as it moves to XCT , pr soon
Issues Resolved
API Changes
Removed:
Platforms Affected
Behavioral/Visual Changes
Would need XCT to run Media
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist