This repository has been archived by the owner on May 1, 2024. It is now read-only.
Added implementation for failure handling method for WkWe… #12327
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…bview.
Description of Change
Added implementation for failure handling method for
WkWebViewRenderer
.WkNavigationDelegate
has 2 methods for failure handling as can be seen here.Only one of them was implemented as can be seen from the source of
WkWebViewRenderer
here.Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
On iOS, when loading a url in the
WebView
, if there is no internet connection available, theWebView
should fire a Navigated event with WebNavigationResult.Failure.Before/After Screenshots
Not applicable
Testing Procedure
Tested with iOS 14 simulator.
WebView.Navigated
event.WebView.Navigated
should be called now.PR Checklist