This repository has been archived by the owner on May 1, 2024. It is now read-only.
Fix layout cycle in ViewToRendererConverter #12365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
ViewToRendererConverter was triggering a cross-platform layout pass from its MeasureOverride ... override, which resulted in a layout cycle. This change removes that layout pass, which appears to now be unnecessary.
The original layout call was added here:
https://github.com/xamarin/Xamarin.Forms/pull/2586/files#diff-70db430b24c262668bdb1ee9c4ad76ccR96
The call was added to address TitleView layout issues which I suspect may have been a symptom of deferring layout changes on the UI thread; or they may have been a symptom of some other bug entirely. Either way, after removing this line the TitleView layout still appears to be correct.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated test 57910
PR Checklist