This repository has been archived by the owner on May 1, 2024. It is now read-only.
EventArgs for BindingFailed must match Log.Warning #12667
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is the follow-up for the initial XAML BindingDiagnostics PR by @StephaneDelcroix:
#10523
See the bug I logged:
#12645
The change I'm making allows binding failures to show up properly in VS's binding failures pane:
Issues Resolved
API Changes
Changed:
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Made all necessary changes in VS to handle the BindingFailed event from Xamarin. Manually made sure that Android and UWP debugging shows binding failures in the new XAML Binding Failures pane. Tested that double click will "go to code".
PR Checklist