Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue closing the SwipeView swiping #12681

Merged
merged 3 commits into from
Nov 27, 2020
Merged

[Android] Fix issue closing the SwipeView swiping #12681

merged 3 commits into from
Nov 27, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Fix issue closing the SwipeView swiping on Android.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Launch Core Gallery on a physical device; navigate to the issue 12541; then open the SwipeView several times and swipe to close it. If it always closes without problems, the test has passed.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added a/listview Problems with the ListView/TableView blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. labels Nov 2, 2020
@PureWeen PureWeen added this to the 5.0.0 milestone Nov 5, 2020
Copy link
Contributor

@mattleibow mattleibow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on the close each time, but I think there is now another issue as a result. If I open and then "open" again by swiping left, then it closes.

I think the logic needs to check to see which direction the swipe is going to close it before closing.

@rmarinho
Copy link
Member

@mattleibow isn't tapping the cell closing it ?

@mattleibow
Copy link
Contributor

mattleibow commented Nov 16, 2020

@rmarinho Yes, but this was more a swipe... I had a look at Teams and Mail and the swipe can be used to open the actions. And then if you swipe again I'd doesn't close but selects the default action. On iOS at least.

@rmarinho
Copy link
Member

Ah i got what you saying , i tested now and see that. But also i tested just with 5.0.0 without this change and the behavior is the same. So i think it's not particular to this issue.

@rmarinho rmarinho merged commit 294cdee into 5.0.0 Nov 27, 2020
@rmarinho rmarinho deleted the fix-12541 branch November 27, 2020 15:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a/listview Problems with the ListView/TableView a/swipeview blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. p/Android t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Android Swipeview finicky swipe to close (with video and sample repo)
5 participants