Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Default enable Android accessibility improvements #15075

Merged
merged 3 commits into from
Apr 7, 2022

Conversation

jfversluis
Copy link
Member

@jfversluis jfversluis commented Jan 19, 2022

Description of Change

Enables the Android accessibility flag by default. First step for taking out all the code that this enables/disables and make that functionality the default behavior.

Additionally this does introduce a new flag to revert to the (now) old behavior so that people can opt-out for the time being.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Shouldn't be none except for better accessibility features

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jfversluis jfversluis mentioned this pull request Jan 24, 2022
2 tasks
@jfversluis jfversluis changed the title Update Flags.cs Default enable Android accessibility improvements Apr 7, 2022
@rachelkang rachelkang merged commit 44e4761 into 5.0.0 Apr 7, 2022
@rachelkang rachelkang deleted the enable-a11y-flag-default branch April 7, 2022 16:08
@TomSoPolaris
Copy link

TomSoPolaris commented Jun 22, 2022

Heads up, this change seems to have broken our ability to find accessibility IDs on our suite of Appium automated UI tests. We encountered this when we upgraded from XF 5.0 SR 10 to SR 11

@PureWeen
Copy link
Contributor

@TomSoPolaris can you test with the nuget from this PR once it's readY?
#15436

If it's still not working can you create an issue and provide a sample of your appium tests that stopped working?

@SiNeumann
Copy link

breaks existing test as automation_id/content-desc is no longer present after refresh #15446

@Pastajello
Copy link

Pastajello commented Jul 20, 2022

@jfversluis
should the flag to disable this be "Disable_Accessibility_Experimental" as code indicates or "AccessibilityExperimental" as instruction in release notes says?
image

@TomSoPolaris
Copy link

Looks like we'll try this again once XF 5.0 SR 12 is released #15446 (comment)

@askariya
Copy link

askariya commented Jun 6, 2023

@TomSoPolaris Did you have any luck with newer Xamarin Forms versions? I'm still encountering the content-desc issue.

@TomSoPolaris
Copy link

@TomSoPolaris Did you have any luck with newer Xamarin Forms versions? I'm still encountering the content-desc issue.

We're using Xamarin.Forms 5.0.0.2545 (5.0.0 Service Release 13) now, but I think our QA devs just worked around the issue. I think they changed the android selectors to use Id instead of AccessibilityId.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify we can take out the accessibility feature flag and turn it on by default
8 participants