-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Default enable Android accessibility improvements #15075
Conversation
This reverts commit d3e064d.
Heads up, this change seems to have broken our ability to find accessibility IDs on our suite of Appium automated UI tests. We encountered this when we upgraded from XF 5.0 SR 10 to SR 11 |
@TomSoPolaris can you test with the nuget from this PR once it's readY? If it's still not working can you create an issue and provide a sample of your appium tests that stopped working? |
breaks existing test as automation_id/content-desc is no longer present after refresh #15446 |
@jfversluis |
Looks like we'll try this again once XF 5.0 SR 12 is released #15446 (comment) |
@TomSoPolaris Did you have any luck with newer Xamarin Forms versions? I'm still encountering the content-desc issue. |
We're using Xamarin.Forms 5.0.0.2545 (5.0.0 Service Release 13) now, but I think our QA devs just worked around the issue. I think they changed the android selectors to use Id instead of AccessibilityId. |
Description of Change
Enables the Android accessibility flag by default. First step for taking out all the code that this enables/disables and make that functionality the default behavior.
Additionally this does introduce a new flag to revert to the (now) old behavior so that people can opt-out for the time being.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
Shouldn't be none except for better accessibility features
Before/After Screenshots
Not applicable
Testing Procedure
PR Checklist