Skip to content

Commit

Permalink
[CI] Invert if to workaround a bad variable expansion. (#13698)
Browse files Browse the repository at this point in the history 
This is weird bug in the agent code.
  • Loading branch information
@mandel-macaque
mandel-macaque committed Jan 13, 2022
1 parent 621ec3f commit 1109fce
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions tools/devops/automation/templates/build/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -432,11 +432,14 @@ steps:
set -x
set -e
echo "##vso[task.setvariable variable=macTestsPresent;isOutput=true]Succeeded"
RC=0
make -C $(Build.SourcesDirectory)/xamarin-macios/tests package-tests || RC=$?
if [ $RC -eq 0 ]; then
echo "Setting outpur var macTestsPresent to Succeeded"
echo "##vso[task.setvariable variable=macTestsPresent;isOutput=true]Succeeded"
else
echo "Setting outpur var macTestsPresent to Failed"
echo "##vso[task.setvariable variable=macTestsPresent;isOutput=true]Failed"
fi
exit $RC
Expand Down
2 changes: 1 addition & 1 deletion tools/devops/automation/templates/mac/build.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ steps:
- pwsh: |
Import-Module $Env:SYSTEM_DEFAULTWORKINGDIRECTORY\xamarin-macios\tools\devops\automation\scripts\GitHub.psm1
if ($Env:MAC_TESTS_PRESENT -ne "Succeeded") {
if ($Env:MAC_TESTS_PRESENT -eq "Failed") {
Set-GitHubStatus -Status "error" -Description "Mac tests were not packaged." -Context "$Env:CONTEXT"
New-GitHubComment -Header "Tests failed catastrophically on $Env:CONTEXT" -Emoji ":fire:" -Description "Mac tests were not packaged."
Stop-Pipeline
Expand Down

4 comments on commit 1109fce

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ [CI Build] Tests failed on Build ❌

Tests failed on Build.

API diff

✅ API Diff from stable

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

API Current PR diff

ℹ️ API Diff (from PR only) (please review changes)

View API diff
View dotnet API diff
View dotnet legacy API diff
View dotnet iOS-MacCatalayst API diff

Generator diff

✅ Generator Diff (no change)

Packages generated

View packages

Test results

3 tests failed, 232 tests passed.

Failed tests

  • monotouch-test/Mac [dotnet]/Debug [dotnet]: Failed (Test run failed.
    Tests run: 2571 Passed: 2415 Inconclusive: 9 Failed: 1 Ignored: 155)
  • monotouch-test/Mac [dotnet]/Debug (static registrar) [dotnet]: Failed (Test run failed.
    Tests run: 2568 Passed: 2413 Inconclusive: 9 Failed: 1 Ignored: 154)
  • link sdk/Mac Catalyst [dotnet]/Release [dotnet]: TimedOut (Execution timed out after 1200 seconds.
    No test log file was produced)

Pipeline on Agent XAMBOT-1038.BigSur'
[CI] Invert if to workaround a bad variable expansion. (#13698)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-tvos\TestSummary.md not found.

Pipeline on Agent
[CI] Invert if to workaround a bad variable expansion. (#13698)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (no summary found). 🔥

Result file D:\a\1\s\Reports\TestSummary-iOS64\TestSummary.md not found.

Pipeline on Agent
[CI] Invert if to workaround a bad variable expansion. (#13698)

@vs-mobiletools-engineering-service2
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Tests failed on macOS Mac Catalina (10.15) ❌

Tests failed on Mac Catalina (10.15).

Failed tests are:

  • introspection

Pipeline on Agent
[CI] Invert if to workaround a bad variable expansion. (#13698)

Please sign in to comment.