Skip to content

Commit

Permalink
Bump Xamarin.MacDev to get fix for #5277. (#5284)
Browse files Browse the repository at this point in the history 
Commit list for xamarin/Xamarin.MacDev:

* xamarin/Xamarin.MacDev@44e90a2 Keys in property list dictionaries aren't necessarily unique. Fixes xamarin-macios#5277. (#39) (#41)
* xamarin/Xamarin.MacDev@c81c625 Get rid of spurious <ItemGroup>
* xamarin/Xamarin.MacDev@d1d3fa4 Remove packagerefs. Leads to unintended problems (see discussion xamarin/md-addins#3946) (#38)

Diff: xamarin/Xamarin.MacDev@179f720...44e90a2

Fixes #5277.
  • Loading branch information
@rolfbjarne
rolfbjarne authored Dec 19, 2018
1 parent 0406829 commit 12adbf6
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion external/Xamarin.MacDev
Submodule Xamarin.MacDev updated 3 files
+4 −2 Xamarin.MacDev/PListObject.cs
+2 −7 Xamarin.MacDev/Xamarin.MacDev.csproj
+2 −7 Xamarin.MacDev/Xamarin.iOSDev.csproj

3 comments on commit 12adbf6

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Build succeeded
✅ API Diff (from stable)
ℹ️ API Diff (from PR only) (please review changes)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

1 tests failed, 0 tests skipped, 283 tests passed.

Failed tests

  • MSBuild tests/iOS: Failed (Execution failed with exit code 2)

@rolfbjarne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures are unrelated

@rolfbjarne
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting state to success where context is continuous-integration/jenkins/branch.

No blocking issues found

Please sign in to comment.