Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
NativeAOT: Reenable
-dead_strip
platform linker optimization by def…
…ault (#20796) ### Description NativeAOT now properly marks all symbols as non-deadstrippable in the object file it generates: dotnet/runtime@d9a6607 And uses `-dead_strip` as the default build option. In this PR we are doing the same - reenabling the `-dead_strip` as the default platform linker switch. This reverts previous workaround introduced in: f212f6b ### Size savings | MySingleView | Main | This PR | diff (%) | |--------------|------|---------|----------| | SOD (MB) | 2,87 | 2,70 | -5,99% | |,ipa (MB) | 1,22 | 1,17 | -4,61% | Even though this brings `4-5%` size reduction for a MySingleView app, the size savings are not proportional to the app size, as the savings are coming from stripping native libraries only. Based on measurements reported in dotnet/runtime@d9a6607 the actual expected savings for a MAUI app are around `~1.5%`. --- Fixes #18605 and dotnet/runtime#88032 --------- Co-authored-by: Ivan Povazan <ivan.povazan@gmail.com>
- Loading branch information
1ca69f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS X64 - Mac Sonoma (14) passed 💻
✅ All tests on macOS X64 - Mac Sonoma (14) passed.
Pipeline on Agent
Hash: 1ca69f3ab58bc5d79651372dfbb1c1cbb66cb155 [CI build]
1ca69f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Monterey (12) passed 💻
✅ All tests on macOS M1 - Mac Monterey (12) passed.
Pipeline on Agent
Hash: 1ca69f3ab58bc5d79651372dfbb1c1cbb66cb155 [CI build]
1ca69f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ [CI Build] Windows Integration Tests failed ❌
❌ Failed ❌
Pipeline on Agent
Hash: 1ca69f3ab58bc5d79651372dfbb1c1cbb66cb155 [CI build]
1ca69f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💻 [CI Build] Tests on macOS M1 - Mac Ventura (13) passed 💻
✅ All tests on macOS M1 - Mac Ventura (13) passed.
Pipeline on Agent
Hash: 1ca69f3ab58bc5d79651372dfbb1c1cbb66cb155 [CI build]
1ca69f3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ API diff for current PR / commit
Legacy Xamarin (No breaking changes)
iOS(no change detected)tvOS(no change detected)watchOS(no change detected)macOS(no change detected)NET (empty diffs)
iOS: (empty diff detected)tvOS: (empty diff detected)MacCatalyst: (empty diff detected)macOS: (empty diff detected)✅ API diff vs stable
Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET
ℹ️ Generator diff
Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)
Pipeline on Agent
Hash: 1ca69f3ab58bc5d79651372dfbb1c1cbb66cb155 [CI build]
This comment was marked as outdated.
Sorry, something went wrong.