Skip to content

Commit

Permalink
[tests] Fix tests that depend on tool output
Browse files Browse the repository at this point in the history
Lot of tests depend on comparing text in tool output. In xbuild, this
was logged with `MessageImportance.Normal` but in msbuild the default is
`MessageImportance.Low`. So, now the tool output doesn't show up in the
normal verbosity log, causing the build to fail.

Due to the number of tests depending on this, the default is changed to
`diagnosticMSBuild = true`.

A better way would probably (future) be to use a custom logger and get the output
from the logging events.
  • Loading branch information
radical committed May 22, 2018
1 parent 6fc89ab commit 26abe1b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions tests/common/mac/ProjectTestHelpers.cs
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ public class UnifiedTestConfig
public UnifiedTestConfig (string tmpDir)
{
TmpDir = tmpDir;
DiagnosticMSBuild = true;
}
}

Expand Down

0 comments on commit 26abe1b

Please sign in to comment.