Skip to content

Commit

Permalink
[monotouch-test] Don't run the mono tests for the System.Drawing type…
Browse files Browse the repository at this point in the history 
…s in .NET (#9464)

A System.Drawing.Point test fails because it tests GetHashCode, which returns
a different value in .NET. None of the System.Drawing tests actually test any
of our code (when using .NET), so the fix is to just not include the
System.Drawing tests in the first place.

Fixes this test failure:

    MonoTests.System.Drawing.PointTest
        [FAIL] GetHashCodeTest :   #1
            Expected: 32
            But was:  1527927283
                at MonoTests.System.Drawing.PointTest.GetHashCodeTest() in /Users/rolf/work/maccore/squashed-onedotnet/xamarin-macios/builds/mono-ios-sdk-destdir/ios-sources/mcs/class/System.Drawing/Test/System.Drawing/TestPoint.cs:line 198
  • Loading branch information
@rolfbjarne
rolfbjarne authored Aug 24, 2020
1 parent d29356d commit 5462242
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions tests/monotouch-test/dotnet/iOS/monotouch-test.csproj
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,24 +48,6 @@
</Compile>
<Compile Include="..\..\..\..\tests\test-libraries\TrampolineTest.generated.cs" />
<Compile Include="..\..\..\..\tests\test-libraries\RegistrarTest.generated.cs" />
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestPoint.cs">
<Link>System.Drawing\TestPoint.cs</Link>
</Compile>
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestPointF.cs">
<Link>System.Drawing\TestPointF.cs</Link>
</Compile>
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestRectangle.cs">
<Link>System.Drawing\TestRectangle.cs</Link>
</Compile>
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestRectangleF.cs">
<Link>System.Drawing\TestRectangleF.cs</Link>
</Compile>
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestSize.cs">
<Link>System.Drawing\TestSize.cs</Link>
</Compile>
<Compile Include="..\..\..\..\builds\mono-ios-sdk-destdir\ios-sources\mcs\class\System.Drawing\Test\System.Drawing\TestSizeF.cs">
<Link>System.Drawing\TestSizeF.cs</Link>
</Compile>
<Compile Include="..\..\..\api-shared\ObjCRuntime\RegistrarTest.cs">
<Link>shared\ObjCRuntime\RegistrarTest.cs</Link>
</Compile>
Expand Down

4 comments on commit 5462242

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests tvOS (DDFun) 🔥

Not enough free space in the host.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS (Cambridge) ❌

Device tests failed on VSTS: device tests iOS (Cambridge).

Test results

150 tests' device not found, 0 tests passed.

Pipeline on Agent XI-IRON-MAN

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥

✅ Provisioning succeeded
✅ Build succeeded
✅ Packages built successfully

View packages

✅ API Diff (from stable)
✅ API Diff (from PR only) (no change)
✅ Generator Diff (no change)
🔥 Test run failed 🔥

Test results

7 tests failed, 181 tests passed.

Failed tests

  • mscorlib/Mac Full/Debug: Failed
  • mscorlib/Mac Modern/Debug: Failed
  • mscorlib Part 2/iOS Unified 32-bits - simulator/Debug: Failed
  • mscorlib Part 2/iOS Unified 64-bits - simulator/Debug: Failed
  • mscorlib Part 2/tvOS - simulator/Debug: Failed
  • mscorlib Part 2/watchOS 32-bits - simulator/Debug: Failed
  • MTouch tests/NUnit: Failed (Execution failed with exit code 1)

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests iOS (DDFun) ❌

Device tests failed on VSTS: device tests iOS (DDFun).

Test results

26 tests failed, 124 tests passed.

Failed tests

  • [NUnit] Mono BCL tests group 2/iOS Unified 64-bits - device/Debug: Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/Debug: Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/Release: Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed
  • mscorlib Part 2/iOS Unified 64-bits - device/Debug: SGenConc: Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Crashed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug, profiling): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Release: Failed
  • monotouch-test/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (dynamic registrar): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Release (all optimizations): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (all optimizations): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug: SGenConc: Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter): Crashed
  • monotouch-test/iOS Unified 64-bits - device/Debug (interpreter -mscorlib): Crashed
  • link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: dylib (debug): Failed
  • link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed
  • link sdk/iOS Unified 64-bits - device/Release: Failed
  • link sdk/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (release): Failed
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug): Failed
  • [xUnit] Mono SystemXunit/iOS Unified 64-bits - device/AssemblyBuildTarget: SDK framework (debug, profiling): Failed

Pipeline on Agent XAMTESTMAC01

Please sign in to comment.