Skip to content

Commit

Permalink
[tools] Remove BaseProfile.GetNamespace, it's not used. (#9533)
Browse files Browse the repository at this point in the history
  • Loading branch information
rolfbjarne authored Aug 28, 2020
1 parent 2e8f615 commit cb3c835
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 10 deletions.
5 changes: 0 additions & 5 deletions tools/linker/BaseProfile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,5 @@ public abstract class BaseProfile : Profile {

// return assembly name without extension (.dll)
public abstract string ProductAssembly { get ; }

public virtual string GetNamespace (string nspace)
{
return nspace;
}
}
}
5 changes: 0 additions & 5 deletions tools/linker/MonoTouch.Tuner/MonoTouchProfile.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,6 @@ public override string ProductAssembly {
get { return product_assembly; }
}

public override string GetNamespace (string nspace)
{
return nspace;
}

public void SetProductAssembly (string assembly)
{
product_assembly = assembly;
Expand Down

4 comments on commit cb3c835

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (Cambridge) 🔥

Not enough free space in the host.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 Tests failed catastrophically on VSTS: device tests iOS (DDFun) 🔥

Not enough free space in the host.

Pipeline on Agent

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device tests failed on VSTS: device tests tvOS (DDFun) ❌

Device tests failed on VSTS: device tests tvOS (DDFun).

Test results

1 tests failed, 149 tests passed.

Failed tests

  • dont link/tvOS - device/AssemblyBuildTarget: SDK framework (release): Crashed

Pipeline on Agent XAMTESTMAC18

@xamarin-release-manager
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build was (probably) aborted

🔥 Jenkins job (on internal Jenkins) failed in stage(s) 'Test run' 🔥 : org.jenkinsci.plugins.workflow.steps.FlowInterruptedException

Provisioning succeeded
Build succeeded
✅ Packages built successfully

View packages

API Diff (from stable)
API Diff (from PR only) (no change)
Generator Diff (no change)
🔥 Test run failed 🔥

Test results

Test run in progress: InProgress, Waiting: 1, Building: 2, BuildQueued: 33, Built: 121, RunQueued: 14, Succeeded: 21, Ignored: 1028

Please sign in to comment.