Skip to content

Commit

Permalink
[release/8.0.1xx] [NerabyInteraction] Add support for xcode 15. (#19315)
Browse files Browse the repository at this point in the history
Backport of #19273

---------

Co-authored-by: Manuel de la Pena Saenz <mandel@microsoft.com>
Co-authored-by: GitHub Actions Autoformatter <github-actions-autoformatter@xamarin.com>
  • Loading branch information
3 people authored Oct 24, 2023
1 parent e41a5a3 commit e1db920
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 19 deletions.
2 changes: 2 additions & 0 deletions src/NearbyInteraction/Enums.cs
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ public enum NIErrorCode : long {
UserDidNotAllow = -5884,
AccessoryPeerDeviceUnavailable = -5882,
InvalidARConfiguration = -5883,
IncompatiblePeerDevice = -5881,
ActiveExtendedDistanceSessionsLimitExceeded = -5880,
}

[Watch (8, 0), NoTV, NoMac, iOS (14, 0)]
Expand Down
17 changes: 16 additions & 1 deletion src/nearbyinteraction.cs
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ interface NIConfiguration : NSCopying, NSSecureCoding { }
[MacCatalyst (14, 0)]
[BaseType (typeof (NSObject))]
[DisableDefaultCtor]
interface NIDiscoveryToken : NSCopying, NSSecureCoding { }
interface NIDiscoveryToken : NSCopying, NSSecureCoding {
[Watch (10, 0), NoTV, NoMac, iOS (17, 0), MacCatalyst (17, 0)]
[Export ("deviceCapabilities", ArgumentSemantic.Copy)]
INIDeviceCapability DeviceCapabilities { get; }
}

[Watch (8, 0), NoTV, NoMac, iOS (14, 0)]
[MacCatalyst (14, 0)]
Expand All @@ -57,6 +61,10 @@ interface NINearbyPeerConfiguration {
[NoWatch, iOS (16, 0), MacCatalyst (16, 0), NoTV, NoMac]
[Export ("cameraAssistanceEnabled")]
bool CameraAssistanceEnabled { [Bind ("isCameraAssistanceEnabled")] get; set; }

[Watch (10, 0), NoTV, NoMac, iOS (17, 0), MacCatalyst (17, 0)]
[Export ("extendedDistanceMeasurementEnabled")]
bool ExtendedDistanceMeasurementEnabled { [Bind ("isExtendedDistanceMeasurementEnabled")] get; set; }
}

[Watch (8, 0), NoTV, NoMac, iOS (14, 0)]
Expand Down Expand Up @@ -231,6 +239,13 @@ interface NIDeviceCapability {
[Abstract]
[Export ("supportsCameraAssistance")]
bool SupportsCameraAssistance { get; }

[Watch (10, 0), NoTV, NoMac, iOS (17, 0), MacCatalyst (17, 0)]
#if XAMCORE_5_0
[Abstract]
#endif
[Export ("supportsExtendedDistanceMeasurement")]
bool SupportsExtendedDistanceMeasurement { get; }
}

[Watch (9, 0), NoTV, NoMac, iOS (16, 0), MacCatalyst (16, 0)]
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!incorrect-protocol-member! NIDeviceCapability::supportsExtendedDistanceMeasurement is REQUIRED and should be abstract

This file was deleted.

1 change: 1 addition & 0 deletions tests/xtro-sharpie/iOS-NearbyInteraction.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!incorrect-protocol-member! NIDeviceCapability::supportsExtendedDistanceMeasurement is REQUIRED and should be abstract
6 changes: 0 additions & 6 deletions tests/xtro-sharpie/iOS-NearbyInteraction.todo

This file was deleted.

1 change: 1 addition & 0 deletions tests/xtro-sharpie/watchOS-NearbyInteraction.ignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
!incorrect-protocol-member! NIDeviceCapability::supportsExtendedDistanceMeasurement is REQUIRED and should be abstract
6 changes: 0 additions & 6 deletions tests/xtro-sharpie/watchOS-NearbyInteraction.todo

This file was deleted.

6 comments on commit e1db920

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 [CI Build] Test results 🔥

Test results

❌ Tests failed on VSTS: simulator tests

19 tests crashed, 0 tests failed, 0 tests passed.

Failures

❌ bcl tests

🔥 Failed catastrophically on VSTS: simulator tests - bcl (no summary found).

Html Report (VSDrops) Download

❌ cecil tests

🔥 Failed catastrophically on VSTS: simulator tests - cecil (no summary found).

Html Report (VSDrops) Download

❌ dotnettests tests

🔥 Failed catastrophically on VSTS: simulator tests - dotnettests (no summary found).

Html Report (VSDrops) Download

❌ fsharp tests

🔥 Failed catastrophically on VSTS: simulator tests - fsharp (no summary found).

Html Report (VSDrops) Download

❌ framework tests

🔥 Failed catastrophically on VSTS: simulator tests - framework (no summary found).

Html Report (VSDrops) Download

❌ generator tests

🔥 Failed catastrophically on VSTS: simulator tests - generator (no summary found).

Html Report (VSDrops) Download

❌ interdependent_binding_projects tests

🔥 Failed catastrophically on VSTS: simulator tests - interdependent_binding_projects (no summary found).

Html Report (VSDrops) Download

❌ install_source tests

🔥 Failed catastrophically on VSTS: simulator tests - install_source (no summary found).

Html Report (VSDrops) Download

❌ introspection tests

🔥 Failed catastrophically on VSTS: simulator tests - introspection (no summary found).

Html Report (VSDrops) Download

❌ linker tests

🔥 Failed catastrophically on VSTS: simulator tests - linker (no summary found).

Html Report (VSDrops) Download

❌ mac_binding_project tests

🔥 Failed catastrophically on VSTS: simulator tests - mac_binding_project (no summary found).

Html Report (VSDrops) Download

❌ mmp tests

🔥 Failed catastrophically on VSTS: simulator tests - mmp (no summary found).

Html Report (VSDrops) Download

❌ mononative tests

🔥 Failed catastrophically on VSTS: simulator tests - mononative (no summary found).

Html Report (VSDrops) Download

❌ monotouch tests

🔥 Failed catastrophically on VSTS: simulator tests - monotouch (no summary found).

Html Report (VSDrops) Download

❌ msbuild tests

🔥 Failed catastrophically on VSTS: simulator tests - msbuild (no summary found).

Html Report (VSDrops) Download

❌ mtouch tests

🔥 Failed catastrophically on VSTS: simulator tests - mtouch (no summary found).

Html Report (VSDrops) Download

❌ xammac tests

🔥 Failed catastrophically on VSTS: simulator tests - xammac (no summary found).

Html Report (VSDrops) Download

❌ xcframework tests

🔥 Failed catastrophically on VSTS: simulator tests - xcframework (no summary found).

Html Report (VSDrops) Download

❌ xtro tests

🔥 Failed catastrophically on VSTS: simulator tests - xtro (no summary found).

Html Report (VSDrops) Download

Successes

Pipeline on Agent
Hash: e1db920d4e92fc66e92dc811fc43102eebf42a01 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Windows Integration Tests passed 💻

All Windows Integration Tests passed.

Pipeline on Agent
Hash: e1db920d4e92fc66e92dc811fc43102eebf42a01 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻

All tests on macOS M1 - Mac Ventura (13.0) passed.

Pipeline on Agent
Hash: [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💻 [CI Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻

All tests on macOS M1 - Mac Big Sur (11.5) passed.

Pipeline on Agent
Hash: [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ API diff for current PR / commit

Legacy Xamarin (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS (no change detected)
  • watchOS: vsdrops gist (No breaking changes)
  • macOS (no change detected)
.NET (No breaking changes)
  • iOS: vsdrops gist (No breaking changes)
  • tvOS: (empty diff detected)
  • MacCatalyst: vsdrops gist (No breaking changes)
  • macOS: (empty diff detected)

✅ API diff vs stable

Legacy Xamarin (No breaking changes)
.NET (No breaking changes)
Legacy Xamarin (stable) vs .NET

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: e1db920d4e92fc66e92dc811fc43102eebf42a01 [CI build]

@vs-mobiletools-engineering-service2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📚 [CI Build] Artifacts 📚

Packages generated

View packages

Pipeline on Agent
Hash: [CI build]

Please sign in to comment.