Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update linker defaults for .NET 6 #10887

Closed
sbomer opened this issue Mar 16, 2021 · 0 comments · Fixed by #10970
Closed

Update linker defaults for .NET 6 #10887

sbomer opened this issue Mar 16, 2021 · 0 comments · Fixed by #10970
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri1 .NET 6: important for stable release feature A feature to be implemented
Milestone
.NET 6

Comments

@sbomer
Copy link
Contributor

sbomer commented Mar 16, 2021

In dotnet/sdk#16327, the .NET SDK is changing the linker defaults to TrimMode=link, with SuppressTrimAnalysisWarnings=false. Xamarin-macios should consider doing the following when this change flows:
@rolfbjarne rolfbjarne added this to the .NET 6 milestone Mar 16, 2021
@rolfbjarne rolfbjarne added dotnet An issue or pull request related to .NET (6) feature A feature to be implemented dotnet-pri1 .NET 6: important for stable release labels Mar 16, 2021
jonathanpeppers added a commit to jonathanpeppers/xamarin-macios that referenced this issue Mar 25, 2021
@jonathanpeppers
[dotnet] default $(SuppressTrimAnalysisWarnings) to true
85cbac3 
Fixes: xamarin#10887

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
@jonathanpeppers jonathanpeppers mentioned this issue Mar 25, 2021
Merged
jonathanpeppers added a commit that referenced this issue Mar 26, 2021
@jonathanpeppers
[dotnet] default $(SuppressTrimAnalysisWarnings) to true (#10970)
7bf3e8d 
Fixes: #10887

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
tj-devel709 pushed a commit that referenced this issue Apr 7, 2021
@jonathanpeppers
[dotnet] default $(SuppressTrimAnalysisWarnings) to true (#10970)
333291b 
Fixes: #10887

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
@ghost ghost locked as resolved and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dotnet An issue or pull request related to .NET (6) dotnet-pri1 .NET 6: important for stable release feature A feature to be implemented
Projects
None yet
Milestone
.NET 6
Development

Successfully merging a pull request may close this issue.

[dotnet] default $(SuppressTrimAnalysisWarnings) to true jonathanpeppers/xamarin-macios
2 participants
@rolfbjarne @sbomer