[PHASE] Add suppport for Xcode13 beta 2. #12098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel-macaque
added
the
note-highlight
tj-devel709
reviewed
Jul 12, 2021
src/phase.cs
Outdated
| public enum PhaseSpatializationMode : long { | ||
| utomatic = 0, | ||
| lwaysUseBinaural = 1, | ||
| lwaysUseChannelBased = 2, |
There was a problem hiding this comment.
Looks like the 'A's got removed!
There was a problem hiding this comment.
Good catch, I probably did x+1 in vim ;)
tj-devel709
reviewed
Jul 12, 2021
tj-devel709
reviewed
Jul 12, 2021
src/phase.cs
Outdated
|
|
||
| [Export ("endPoint", ArgumentSemantic.Assign)] | ||
| [unsupported ExtVector: double __attribute__((ext_vector_type(2)))] EndPoint { get; set; } | ||
| */ |
There was a problem hiding this comment.
Did you want these included?
There was a problem hiding this comment.
Yes, since it is not supported but we do not want to need to write it.
tj-devel709
reviewed
Jul 12, 2021
src/phase.cs
Outdated
| double Evaluate (double x); | ||
|
|
||
| //[Export ("startPoint")] | ||
| //[unsupported ExtVector: double __attribute__((ext_vector_type(2)))] StartPoint { get; } |
There was a problem hiding this comment.
Also wondering if you intended for these to be included
tj-devel709
reviewed
Jul 12, 2021
tj-devel709
reviewed
Jul 12, 2021
tj-devel709
reviewed
Jul 12, 2021
tj-devel709
reviewed
Jul 12, 2021
src/phase.cs
Outdated
|
|
||
| [Export ("worldTransform", ArgumentSemantic.Assign)] | ||
| simd_float4x4 WorldTransform { get; set; } | ||
| */ |
There was a problem hiding this comment.
Yes, as with the others.
tj-devel709
reviewed
Jul 12, 2021
src/phase.cs
Outdated
| bool Start ([NullAllowed] out NSError error); | ||
|
|
||
| [Export ("seekToTime:completionBlock:")] | ||
| bool SeekToTime (double time, [NullAllowed] Action<PhaseSoundEventSeekHandlerReason> completionBlock); |
There was a problem hiding this comment.
Suggested change
| bool SeekToTime (double time, [NullAllowed] Action<PhaseSoundEventSeekHandlerReason> completionBlock); | |
| bool Seek (double time, [NullAllowed] Action<PhaseSoundEventSeekHandlerReason> completionBlock); |
Also would this one be a candidate for async?
rolfbjarne
requested changes
Jul 12, 2021
src/phase.cs
Outdated
| { | ||
| /* | ||
| [Export ("initWithEndPoint:curveType:")] | ||
| IntPtr Constructor ([unsupported ExtVector: double __attribute__((ext_vector_type(2)))] endPoint, PhaseCurveType curveType); |
There was a problem hiding this comment.
double __attribute__((ext_vector_type(2))) is an OpenTK.Vector2d (and you'll need the [MarshalDirective] attribute + manual tests).
mandel-macaque
commented
Jul 12, 2021
mandel-macaque
commented
Jul 12, 2021
Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com>
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 87 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
spouliot
suggested changes
Jul 19, 2021
tests/xtro-sharpie/SimdCheck.cs
Outdated
| @@ -43,6 +43,8 @@ class NativeSimdInfo | |||
| { "vector_uint2", new NativeSimdInfo { Managed = "Vector2i", }}, | |||
| { "vector_uint3", new NativeSimdInfo { Managed = "Vector3i", }}, | |||
| { "vector_uint4", new NativeSimdInfo { Managed = "Vector4i", }}, | |||
| // simd_floatX is typedefed to vector_doubleX | |||
There was a problem hiding this comment.
I think you mean // simd_doubleX is typedefed to vector_doubleX ?
| } |
There was a problem hiding this comment.
New line! Either Rol of you have to agree on one lol
There was a problem hiding this comment.
I think we agree not to change existing stuff ;-)
src/phase.cs
Outdated
| NotFound = 1346925665, | ||
| BadData = 1346925666, | ||
| InvalidInstance = 1346925667, | ||
| APIMisuse = 1346925668, |
🔥 Tests failed catastrophically on Build (no summary found). 🔥Result file $(TEST_SUMMARY_PATH) not found. |
spouliot
suggested changes
Jul 20, 2021
tests/xtro-sharpie/SimdCheck.cs
Outdated
| @@ -43,6 +43,8 @@ class NativeSimdInfo | |||
| { "vector_uint2", new NativeSimdInfo { Managed = "Vector2i", }}, | |||
| { "vector_uint3", new NativeSimdInfo { Managed = "Vector3i", }}, | |||
| { "vector_uint4", new NativeSimdInfo { Managed = "Vector4i", }}, | |||
| // simd_dobleX is typedefed to vector_doubleX | |||
There was a problem hiding this comment.
missing u (at least in English and French)
There was a problem hiding this comment.
In Spanish is ok, doble :)
tools/common/Frameworks.cs
Outdated
| @@ -583,6 +584,7 @@ public static Frameworks GetwatchOSFrameworks (bool is_simulator_build) | |||
| { "Intents", "Intents", 14,0 }, | |||
|
|
|||
| { "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator /* no headers in beta 2 */ }, | |||
| { "Phase", "PHASE", new Version (15,0), NotAvailableInSimulator /* no headers in beta 2 */ }, | |||
src/phase.cs
Outdated
|
|
||
| namespace Phase { | ||
|
|
||
| [Mac (12,0), NoWatch, TV (15,0), iOS (15,0), MacCatalyst (15,0)] |
There was a problem hiding this comment.
It's not in tvOS so you need to remove TV (15,0)... everywhere in the file
src/phase.cs
Outdated
|
|
||
| [Async] | ||
| [Export ("unregisterAssetWithIdentifier:completion:")] | ||
| void UnregisterAssetWithIdentifier (string identifier, [NullAllowed] Action<bool> handler); |
src/phase.cs
Outdated
| void AddRangeForInputValuesAbove (double value, double fullGainAtValue, PhaseCurveType fadeCurveType, PhaseSoundEventNodeDefinition subtree); | ||
|
|
||
| [Export ("addRangeWithEnvelope:subtree:")] | ||
| void AddRangeWithEnvelope (PhaseEnvelope envelope, PhaseSoundEventNodeDefinition subtree); |
mandel-macaque
force-pushed
the
phase-xcode13-beta2
branch
from
ed744d6 to
9bb13f3
Compare
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results33 tests failed, 59 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
spouliot
approved these changes
Jul 28, 2021
| @@ -422,7 +423,8 @@ public static Frameworks CreateiOSFrameworks (bool is_simulator_build) | |||
|
|
|||
| { "CoreLocationUI", "CoreLocationUI", 15,0 }, | |||
|
|
|||
| { "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator /* no headers in beta 2 */ } | |||
| { "Chip", "CHIP", new Version (15, 0), NotAvailableInSimulator /* no headers in beta 2 */ }, | |||
| { "Phase", "PHASE", new Version (15,0), NotAvailableInSimulator /* no headers in beta 2 */ }, | |||
There was a problem hiding this comment.
is not a separate entry required for MacCatalyst ?
There was a problem hiding this comment.
Mac Catalyst will pick up the iOS frameworks automatically.
There was a problem hiding this comment.
xamarin-macios/tools/common/Frameworks.cs
Lines 594 to 597 in 524fd24
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results33 tests failed, 59 tests passed.Failed tests
Pipeline on Agent XAMBOT-1094.BigSur' |
rolfbjarne
approved these changes
Aug 3, 2021
dalexsoto
approved these changes
Aug 3, 2021
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 90 tests passed.Failed tests
Pipeline on Agent XAMBOT-1104.BigSur' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.