[DataDetection] Add new framework for Xcode 13 beta 3. #12259
Conversation
mandel-macaque
added
the
note-highlight
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
There was a problem hiding this comment.
base does not have a default ctor
I don't see how having one here would be helpful (since you can't set any of the values)
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
| } | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof (DDDetectedValue))] |
|
@spouliot will address the review and will set it to do-not-merge |
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 90 tests passed.Failed tests
Pipeline on Agent XAMBOT-1100.BigSur' |
| @@ -2051,6 +2051,7 @@ IOS_FRAMEWORKS = \ | |||
| CoreSpotlight \ | |||
| CoreTelephony \ | |||
| CoreText \ | |||
| DataDetection \ | |||
There was a problem hiding this comment.
You need to add the framework to MACCATALYST_FRAMEWORKS too if you want these bindings in Mac Catalyst (like your availability attributes seem to indicate).
| namespace DataDetection { | ||
|
|
||
| [iOS (15,0), MacCatalyst (15,0)] | ||
| [BaseType (typeof(NSObject))] |
There was a problem hiding this comment.
| [BaseType (typeof(NSObject))] | |
| [BaseType (typeof (NSObject))] |
small
❌ [PR Build] Tests failed on Build ❌Tests failed on Build. API diff✅ API Diff from stable View API diffAPI & Generator diffℹ️ API Diff (from PR only) (please review changes) GitHub pagesResults can be found in the following github pages (it might take some time to publish): Test results2 tests failed, 91 tests passed.Failed tests
Pipeline on Agent XAMBOT-1096.BigSur' |
|
Never got to land, makes no sense to try and get it in in the current state. |
No description provided.